Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 11880002: Add components_unittests to bots target (Closed)

Created:
7 years, 11 months ago by kaiwang
Modified:
7 years, 11 months ago
Reviewers:
iannucci, Jói
CC:
chromium-reviews, cmp, Nicolas Sylvain
Visibility:
Public.

Description

We are moving browser components (http://www.chromium.org/developers/design-documents/browser-components ) from src/content/components to src/components. So it does not make sense any more to keep components tests in content_unittests. BUG=169312 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176643

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove 2 unnecessary dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/all.gyp View 1 10 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kaiwang
7 years, 11 months ago (2013-01-11 20:54:12 UTC) #1
kaiwang
7 years, 11 months ago (2013-01-11 21:03:34 UTC) #2
kaiwang
Add iannucci as reviewer as Chase suggested
7 years, 11 months ago (2013-01-11 23:04:04 UTC) #3
iannucci
lgtm w/ 1 question https://chromiumcodereview.appspot.com/11880002/diff/1/build/all.gyp File build/all.gyp (right): https://chromiumcodereview.appspot.com/11880002/diff/1/build/all.gyp#newcode687 build/all.gyp:687: '../content/content.gyp:content_unittests', This is odd... why ...
7 years, 11 months ago (2013-01-12 00:30:47 UTC) #4
kaiwang
https://chromiumcodereview.appspot.com/11880002/diff/1/build/all.gyp File build/all.gyp (right): https://chromiumcodereview.appspot.com/11880002/diff/1/build/all.gyp#newcode687 build/all.gyp:687: '../content/content.gyp:content_unittests', Didn't notice :) Removed both.
7 years, 11 months ago (2013-01-12 00:52:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/11880002/1004
7 years, 11 months ago (2013-01-12 01:54:47 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
7 years, 11 months ago (2013-01-12 03:38:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/11880002/1004
7 years, 11 months ago (2013-01-14 06:55:03 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-14 08:09:00 UTC) #9
Message was sent while issue was closed.
Change committed as 176643

Powered by Google App Engine
This is Rietveld 408576698