Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5913)

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 11879023: base: Add a couple Pref unit tests to base_unittests target. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move json_pref_store_unittest.cc back to unit_tests - ios_dbg_simulator is not happy with it Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index 056af3c7ab3950f038b6e4ef81aa1ac3d89fceef..a2d62f93733f93b8d06230cb8c58a149bf3909d1 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -19,6 +19,7 @@
'chrome_resources.gyp:theme_resources',
'common',
'../base/base.gyp:test_support_base',
+ '../base/base.gyp:base_prefs_test_support',
'../content/content.gyp:content_app',
'../content/content.gyp:test_support_content',
'../media/media.gyp:media_test_support',
@@ -253,13 +254,6 @@
'test/ppapi/ppapi_test.cc',
'test/ppapi/ppapi_test.h',
- # TODO(joi): Move to 'base_prefs' target in base/base.gyp once
- # Prefs move is complete and dependencies have been broken.
- '../base/prefs/testing_pref_store.cc',
- '../base/prefs/testing_pref_store.h',
- '../base/prefs/pref_store_observer_mock.cc',
- '../base/prefs/pref_store_observer_mock.h',
-
'../ui/gfx/image/image_unittest_util.h',
'../ui/gfx/image/image_unittest_util.cc',
'../webkit/quota/mock_quota_manager.cc',
@@ -1593,11 +1587,9 @@
# TODO(joi): Move to 'base_prefs' target in base/base.gyp once
# Prefs move is complete and dependencies have been broken.
+ '../base/prefs/json_pref_store_unittest.cc',
tfarina 2013/01/19 20:50:59 We can move it back to base_unittests and exclude
Jói 2013/01/21 10:33:22 If that passes all bots then I have no issue with
'../base/prefs/public/pref_change_registrar_unittest.cc',
'../base/prefs/public/pref_member_unittest.cc',
- '../base/prefs/overlay_user_pref_store_unittest.cc',
- '../base/prefs/pref_value_map_unittest.cc',
- '../base/prefs/json_pref_store_unittest.cc',
# TODO(joi): Move the google_apis tests to a separate
# google_apis_unittests executable.
« no previous file with comments | « base/base.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698