cc: Move tile sorting into separate function and add trace event.

cc: Move tile sorting into separate function and add trace event.

BUG=155209
R=nduca@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177050

[nduca, 2013-01-15 22:40:36]

lgtm but i'd prefer the latter

https://codereview.chromium.org/11879007/diff/4001/cc/tile_manager.cc
File cc/tile_manager.cc (left):

https://codereview.chromium.org/11879007/diff/4001/cc/tile_manager.cc#oldcode246
cc/tile_manager.cc:246: // Sort by bin.
Why not just a local scope...

{
   TRACE_EVENT("cc", "SortTiles")
   std::sort
}

[reveman, 2013-01-15 23:29:19]

https://codereview.chromium.org/11879007/diff/4001/cc/tile_manager.cc
File cc/tile_manager.cc (left):

https://codereview.chromium.org/11879007/diff/4001/cc/tile_manager.cc#oldcode246
cc/tile_manager.cc:246: // Sort by bin.
On 2013/01/15 22:40:36, nduca wrote:
> Why not just a local scope...
> 
> {
>    TRACE_EVENT("cc", "SortTiles")
>    std::sort
> }

I'll keep the SortTiles function as I like the consistency of having all trace
events in the TileManager class map to functions.

[commit-bot: I haz the power, 2013-01-15 23:31:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/11879007/4001

[commit-bot: I haz the power, 2013-01-15 23:31:21]

Failed to apply patch for cc/tile_manager.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/tile_manager.h
  Hunk #1 FAILED at 104.
  1 out of 1 hunk FAILED -- saving rejects to file cc/tile_manager.h.rej

Patch:       cc/tile_manager.h
Index: cc/tile_manager.h
diff --git a/cc/tile_manager.h b/cc/tile_manager.h
index
7496a157eea3abac4e295ca8f747333da68a72f6..159bf8a6b92615cd11f8dba95a719036484a76b3
100644
--- a/cc/tile_manager.h
+++ b/cc/tile_manager.h
@@ -104,6 +104,7 @@ class CC_EXPORT TileManager {
       Tile* tile, WhichTree tree, const TilePriority& new_priority);
 
  private:
+  void SortTiles();
   void ResetBinCounts();
   void AssignGpuMemoryToTiles();
   void FreeResourcesForTile(Tile* tile);

[commit-bot: I haz the power, 2013-01-15 23:37:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/11879007/10001

[commit-bot: I haz the power, 2013-01-16 02:01:49]

Change committed as 177050