Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 11878038: Fix out of bounds array access in memory_details_android.cc. (Closed)

Created:
7 years, 11 months ago by Philippe
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix out of bounds array access in memory_details_android.cc. AddNonChildChromeProcesses() appeared to be crashing sometimes on Android. |cmd_line_args_| can be empty in some rare circumstances. One of them is when GetProcCmdline() is called with a PID which no longer exists. This is possible in case a render process was killed right after the list of processes was read. TEST=Go to chrome://memory BUG=170024 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/memory_details_android.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Philippe
7 years, 11 months ago (2013-01-15 10:31:54 UTC) #1
bulach
lgtm
7 years, 11 months ago (2013-01-15 13:22:52 UTC) #2
Philippe
+ jochen since Nico is probably sleeping currently :)
7 years, 11 months ago (2013-01-16 14:29:36 UTC) #3
jochen (gone - plz use gerrit)
lgtm
7 years, 11 months ago (2013-01-16 15:50:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11878038/1
7 years, 11 months ago (2013-01-16 15:52:17 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 17:42:58 UTC) #6
Message was sent while issue was closed.
Change committed as 177167

Powered by Google App Engine
This is Rietveld 408576698