Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 11878002: Breakpad: Remove redundant Gyp setting and misleading comment (Closed)

Created:
7 years, 11 months ago by Mark Seaborn
Modified:
7 years, 11 months ago
Reviewers:
Yaron, Jay Civelli
CC:
chromium-reviews
Visibility:
Public.

Description

Breakpad: Remove redundant Gyp setting and misleading comment This linux_breakpad=0 assignment for Android is overridden by the later block (which was added in http://src.chromium.org/viewvc/chrome?view=rev&revision=147088): # Configure crash reporting and build options based on release type. 'conditions': [ ['buildtype=="Official"', { # Only report crash dumps for Official builds. 'linux_breakpad%': 1, }, { 'linux_breakpad%': 0, }], ], BUG=105778 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
7 years, 11 months ago (2013-01-11 20:47:41 UTC) #1
Jay Civelli
lgtm
7 years, 11 months ago (2013-01-11 21:57:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/11878002/1
7 years, 11 months ago (2013-01-11 22:04:15 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-12 03:33:55 UTC) #4
Message was sent while issue was closed.
Change committed as 176500

Powered by Google App Engine
This is Rietveld 408576698