Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 11877003: windows: Remove DirectX SDK from search paths for include files and library files. (Closed)

Created:
7 years, 11 months ago by apatrick_chromium
Modified:
7 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

windows: Remove DirectX SDK from search paths for include files and library files. Chrome and its dependencies no longer need D3DX so the Windows Platform SDK is sufficient. WebRTC still needs the directx_sdk_path gyp variable so that is not deleted. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176585

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/common.gypi View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
apatrick_chromium
PTAL
7 years, 11 months ago (2013-01-11 22:32:58 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
7 years, 11 months ago (2013-01-12 01:15:46 UTC) #2
cpu_(ooo_6.6-7.5)
come by and lets talk of what we can do to webrtc to remove it ...
7 years, 11 months ago (2013-01-12 01:18:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/11877003/2001
7 years, 11 months ago (2013-01-12 01:37:40 UTC) #4
commit-bot: I haz the power
Change committed as 176585
7 years, 11 months ago (2013-01-12 19:56:10 UTC) #5
kjellander_chromium
On 2013/01/12 19:56:10, I haz the power (commit-bot) wrote: > Change committed as 176585 I'm ...
7 years, 10 months ago (2013-02-15 15:27:37 UTC) #6
apatrick_chromium
7 years, 10 months ago (2013-02-15 19:51:31 UTC) #7
Message was sent while issue was closed.
Awesome! Thanks.

Powered by Google App Engine
This is Rietveld 408576698