Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: content/browser/web_contents/navigation_entry_impl_unittest.cc

Issue 11876045: [Search] Store and recall search terms using NavigationEntry to improve search term extraction (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: reupload Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string16.h" 5 #include "base/string16.h"
6 #include "base/string_util.h" 6 #include "base/string_util.h"
7 #include "base/time.h" 7 #include "base/time.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "content/browser/site_instance_impl.h" 9 #include "content/browser/site_instance_impl.h"
10 #include "content/browser/web_contents/navigation_entry_impl.h" 10 #include "content/browser/web_contents/navigation_entry_impl.h"
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 } 210 }
211 211
212 // Test timestamps. 212 // Test timestamps.
213 TEST_F(NavigationEntryTest, NavigationEntryTimestamps) { 213 TEST_F(NavigationEntryTest, NavigationEntryTimestamps) {
214 EXPECT_EQ(base::Time(), entry1_->GetTimestamp()); 214 EXPECT_EQ(base::Time(), entry1_->GetTimestamp());
215 const base::Time now = base::Time::Now(); 215 const base::Time now = base::Time::Now();
216 entry1_->SetTimestamp(now); 216 entry1_->SetTimestamp(now);
217 EXPECT_EQ(now, entry1_->GetTimestamp()); 217 EXPECT_EQ(now, entry1_->GetTimestamp());
218 } 218 }
219 219
220 // Test extra data stored in the navigation entry.
221 TEST_F(NavigationEntryTest, NavigationEntryExtraData) {
222 string16 test_data = ASCIIToUTF16("my search terms");
223 string16 output;
224 entry1_->SetExtraData("search_terms", test_data);
225
226 EXPECT_FALSE(entry1_->GetExtraData("non_existent_key", &output));
227 EXPECT_EQ(ASCIIToUTF16(""), output);
228 EXPECT_TRUE(entry1_->GetExtraData("search_terms", &output));
229 EXPECT_EQ(test_data, output);
230 // Data is cleared.
231 entry1_->ClearExtraData("search_terms");
232 // Content in |output| is not modified if data is not present at the key.
233 EXPECT_FALSE(entry1_->GetExtraData("search_terms", &output));
234 EXPECT_EQ(test_data, output);
235 // Using an empty string shows that the data is not present in the map.
236 string16 output2;
237 EXPECT_FALSE(entry1_->GetExtraData("search_terms", &output2));
238 EXPECT_EQ(ASCIIToUTF16(""), output2);
239 }
240
220 } // namespace content 241 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/navigation_entry_impl.cc ('k') | content/public/browser/navigation_entry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698