Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: net/socket/client_socket_factory.cc

Issue 11876044: Remove support for 'system' SSL on Mac (SecureTransport) and Win (SChannel) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review feedback Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_factory.cc
diff --git a/net/socket/client_socket_factory.cc b/net/socket/client_socket_factory.cc
index 881a15c65e347f16d1cf5c515be6719ca5e609df..a058f4989b4d06321eaf0495064e5e465aee439c 100644
--- a/net/socket/client_socket_factory.cc
+++ b/net/socket/client_socket_factory.cc
@@ -10,15 +10,9 @@
#include "build/build_config.h"
#include "net/base/cert_database.h"
#include "net/socket/client_socket_handle.h"
-#if defined(OS_WIN)
-#include "net/socket/ssl_client_socket_nss.h"
-#include "net/socket/ssl_client_socket_win.h"
-#elif defined(USE_OPENSSL)
+#if defined(USE_OPENSSL)
#include "net/socket/ssl_client_socket_openssl.h"
-#elif defined(USE_NSS) || defined(OS_IOS)
-#include "net/socket/ssl_client_socket_nss.h"
-#elif defined(OS_MACOSX)
-#include "net/socket/ssl_client_socket_mac.h"
+#elif defined(USE_NSS) || defined(OS_MACOSX) || defined(OS_WIN)
#include "net/socket/ssl_client_socket_nss.h"
#endif
#include "net/socket/tcp_client_socket.h"
@@ -30,8 +24,6 @@ class X509Certificate;
namespace {
-bool g_use_system_ssl = false;
-
// ChromeOS and Linux may require interaction with smart cards or TPMs, which
// may cause NSS functions to block for upwards of several seconds. To avoid
// blocking all activity on the current task runner, such as network or IPC
@@ -112,25 +104,9 @@ class DefaultClientSocketFactory : public ClientSocketFactory,
#if defined(USE_OPENSSL)
return new SSLClientSocketOpenSSL(transport_socket, host_and_port,
ssl_config, context);
-#elif defined(USE_NSS) || defined(OS_IOS)
+#elif defined(USE_NSS) || defined(OS_MACOSX) || defined(OS_WIN)
return new SSLClientSocketNSS(nss_task_runner, transport_socket,
host_and_port, ssl_config, context);
-#elif defined(OS_WIN)
- if (g_use_system_ssl) {
- return new SSLClientSocketWin(transport_socket, host_and_port,
- ssl_config, context);
- }
- return new SSLClientSocketNSS(nss_task_runner, transport_socket,
- host_and_port, ssl_config,
- context);
-#elif defined(OS_MACOSX)
- if (g_use_system_ssl) {
- return new SSLClientSocketMac(transport_socket, host_and_port,
- ssl_config, context);
- }
- return new SSLClientSocketNSS(nss_task_runner, transport_socket,
- host_and_port, ssl_config,
- context);
#else
NOTIMPLEMENTED();
return NULL;
@@ -168,17 +144,4 @@ ClientSocketFactory* ClientSocketFactory::GetDefaultFactory() {
return g_default_client_socket_factory.Pointer();
}
-// static
-void ClientSocketFactory::UseSystemSSL() {
- g_use_system_ssl = true;
-
-#if defined(OS_WIN)
- // Reflect the capability of SSLClientSocketWin.
- SSLConfigService::SetDefaultVersionMax(SSL_PROTOCOL_VERSION_TLS1);
-#elif defined(OS_MACOSX) && !defined(OS_IOS)
- // Reflect the capability of SSLClientSocketMac.
- SSLConfigService::SetDefaultVersionMax(SSL_PROTOCOL_VERSION_TLS1);
-#endif
-}
-
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698