Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: chrome/browser/chromeos/drive/drive_feed_processor.cc

Issue 11876002: Make largest_changestamp setter/getter asynchronous. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase + comment Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/drive_feed_processor.cc
===================================================================
--- chrome/browser/chromeos/drive/drive_feed_processor.cc (revision 177026)
+++ chrome/browser/chromeos/drive/drive_feed_processor.cc (working copy)
@@ -17,6 +17,21 @@
namespace drive {
+namespace {
+
+// Callback for DriveResourceMetadata::SetLargestChangestamp.
+// Runs |on_complete_callback|. |on_complete_callback| must not be null.
+void RunOnCompleteCallback(const base::Closure& on_complete_callback,
+ DriveFileError error) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK(!on_complete_callback.is_null());
+ DCHECK_EQ(DRIVE_FILE_OK, error);
+
+ on_complete_callback.Run();
+}
+
+} // namespace
+
class DriveFeedProcessor::FeedToEntryProtoMapUMAStats {
public:
FeedToEntryProtoMapUMAStats()
@@ -382,11 +397,11 @@
void DriveFeedProcessor::OnComplete() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- DCHECK(!on_complete_callback_.is_null());
resource_metadata_->set_loaded(true);
- resource_metadata_->set_largest_changestamp(largest_changestamp_);
- on_complete_callback_.Run();
+ resource_metadata_->SetLargestChangestamp(
+ largest_changestamp_,
+ base::Bind(&RunOnCompleteCallback, on_complete_callback_));
}
void DriveFeedProcessor::Clear() {
« no previous file with comments | « chrome/browser/chromeos/drive/drive_feed_loader.cc ('k') | chrome/browser/chromeos/drive/drive_file_system.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698