Allow an AppsV2 build to be configured using GYP.

Allow an AppsV2 build to be configured using GYP.

BUG=134213
TEST=Use GYP_DEFINES="remoting_use_apps_v2=1"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177217

[Jamie, 2013-01-14 21:18:08]

Please pay particularly attention to the GYP changes. It's not a language I'm
particularly familiar with, and it took a  lot of trial and error to get it
working.

[Wez, 2013-01-15 02:24:30]

https://chromiumcodereview.appspot.com/11875021/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://chromiumcodereview.appspot.com/11875021/diff/1/remoting/remoting.gyp#...
remoting/remoting.gyp:24: 'remoting_webapp_apps_v2%': 0,
nit: remoting_use_apps_v2 or remoting_app_v2_webapp (and then
remoting_apps_v2_files)

https://chromiumcodereview.appspot.com/11875021/diff/1/remoting/remoting.gyp#...
remoting/remoting.gyp:1712: '<@(remoting_webapp_apps_v2_js_files)',
Rather than add these here and set them empty for v1, just add them directly to
e.g. remoting_webapp_js_files, e.g:

['remoting_webapp_apps_v2==1', {
'remoting_webapp_js_files': [
  'webapp/background.js',
  'webapp/identity.js',
 ]
]
 
and let GYP merge them with the rest.

Since we don't do anything special w/ the patch file at this level, you could
add it to remoting_webapp_files in a similar manner, to get the necessary
dependency.

https://chromiumcodereview.appspot.com/11875021/diff/1/remoting/webapp/build-...
File remoting/webapp/build-webapp.py (right):

https://chromiumcodereview.appspot.com/11875021/diff/1/remoting/webapp/build-...
remoting/webapp/build-webapp.py:220: '<patch> <other files...> --locales
<locales...>')
nit: Would be cleaner to add --patches akin to --locales...

[Jamie, 2013-01-15 21:57:01]

ptal

https://chromiumcodereview.appspot.com/11875021/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

https://chromiumcodereview.appspot.com/11875021/diff/1/remoting/remoting.gyp#...
remoting/remoting.gyp:24: 'remoting_webapp_apps_v2%': 0,
On 2013/01/15 02:24:31, Wez wrote:
> nit: remoting_use_apps_v2 or remoting_app_v2_webapp (and then
> remoting_apps_v2_files)

Done.

https://chromiumcodereview.appspot.com/11875021/diff/1/remoting/remoting.gyp#...
remoting/remoting.gyp:1712: '<@(remoting_webapp_apps_v2_js_files)',
On 2013/01/15 02:24:31, Wez wrote:
> Rather than add these here and set them empty for v1, just add them directly
to
> e.g. remoting_webapp_js_files, e.g:
> 
> ['remoting_webapp_apps_v2==1', {
> 'remoting_webapp_js_files': [
>   'webapp/background.js',
>   'webapp/identity.js',
>  ]
> ]
>  
> and let GYP merge them with the rest.
> 
> Since we don't do anything special w/ the patch file at this level, you could
> add it to remoting_webapp_files in a similar manner, to get the necessary
> dependency.

I tried that, but the list is replaced, not merged. I think this approach is
fine for a temporary fix.

https://chromiumcodereview.appspot.com/11875021/diff/1/remoting/webapp/build-...
File remoting/webapp/build-webapp.py (right):

https://chromiumcodereview.appspot.com/11875021/diff/1/remoting/webapp/build-...
remoting/webapp/build-webapp.py:220: '<patch> <other files...> --locales
<locales...>')
On 2013/01/15 02:24:31, Wez wrote:
> nit: Would be cleaner to add --patches akin to --locales...

Much cleaner, thanks. Done.

[Wez, 2013-01-16 20:43:57]

lgtm

https://chromiumcodereview.appspot.com/11875021/diff/5001/remoting/webapp/bui...
File remoting/webapp/build-webapp.py (right):

https://chromiumcodereview.appspot.com/11875021/diff/5001/remoting/webapp/bui...
remoting/webapp/build-webapp.py:76: the parent directory, for example
a/main.html.
To the parent directory of what?

[Jamie, 2013-01-16 21:11:34]

FYI

https://chromiumcodereview.appspot.com/11875021/diff/5001/remoting/webapp/bui...
File remoting/webapp/build-webapp.py (right):

https://chromiumcodereview.appspot.com/11875021/diff/5001/remoting/webapp/bui...
remoting/webapp/build-webapp.py:76: the parent directory, for example
a/main.html.
On 2013/01/16 20:43:57, Wez wrote:
> To the parent directory of what?

The parent directory of the web-app. The example is the important point, since
this is not the format you'll get from a git diff. I've updated the comment to
clarify.