Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1187373002: Add wifi_manager.py and WifiUtils.apk from tradefed to public checkout.

Created:
5 years, 6 months ago by navabi1
Modified:
5 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add wifi_manager.py and WifiUtils.apk from tradefed to public checkout. BUG=495153

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -0 lines) Patch
A build/android/apks/README.chromium View 1 chunk +23 lines, -0 lines 5 comments Download
A build/android/apks/WifiUtil.apk View Binary file 0 comments Download
A build/android/pylib/device/wifi_manager.py View 1 chunk +210 lines, -0 lines 3 comments Download

Messages

Total messages: 6 (1 generated)
navabi
https://codereview.chromium.org/1187373002/diff/1/build/android/pylib/device/wifi_manager.py File build/android/pylib/device/wifi_manager.py (right): https://codereview.chromium.org/1187373002/diff/1/build/android/pylib/device/wifi_manager.py#newcode26 build/android/pylib/device/wifi_manager.py:26: WifiUtil is available at build/android/apks/WifiUtil.apk, for more changed this. ...
5 years, 6 months ago (2015-06-18 01:04:58 UTC) #2
perezju
https://codereview.chromium.org/1187373002/diff/1/build/android/apks/README.chromium File build/android/apks/README.chromium (right): https://codereview.chromium.org/1187373002/diff/1/build/android/apks/README.chromium#newcode1 build/android/apks/README.chromium:1: Name: WifiUtil apk maybe call this "Android APKs", so ...
5 years, 6 months ago (2015-06-18 09:53:33 UTC) #3
jbudorick
https://codereview.chromium.org/1187373002/diff/1/build/android/apks/README.chromium File build/android/apks/README.chromium (right): https://codereview.chromium.org/1187373002/diff/1/build/android/apks/README.chromium#newcode1 build/android/apks/README.chromium:1: Name: WifiUtil apk I don't think we want this ...
5 years, 6 months ago (2015-06-18 14:21:48 UTC) #4
navabi
https://codereview.chromium.org/1187373002/diff/1/build/android/apks/README.chromium File build/android/apks/README.chromium (right): https://codereview.chromium.org/1187373002/diff/1/build/android/apks/README.chromium#newcode1 build/android/apks/README.chromium:1: Name: WifiUtil apk On 2015/06/18 14:21:47, jbudorick (ooo til ...
5 years, 6 months ago (2015-06-18 16:52:34 UTC) #5
jbudorick
5 years, 6 months ago (2015-06-19 04:00:06 UTC) #6
On 2015/06/18 at 16:52:34, navabi wrote:
>
https://codereview.chromium.org/1187373002/diff/1/build/android/apks/README.c...
> File build/android/apks/README.chromium (right):
> 
>
https://codereview.chromium.org/1187373002/diff/1/build/android/apks/README.c...
> build/android/apks/README.chromium:1: Name: WifiUtil apk
> On 2015/06/18 14:21:47, jbudorick (ooo til 2015-06-18) wrote:
> > I don't think we want this in build/android/. I think it belongs somewhere
in
> > third_party and should only be DEPSed in for android checkouts, similar to
how
> > we handle the android SDK in third_party/android_tools.
> 
> So for android_tools we've created and maintain a separate git repo that is
then DEPsed. I'm fine putting this in another directory, but I'm reluctant to
create a new repo for a single apk.
> 
> One idea is checking it into the android_tools repo, as it is used as a
testing tool on Android. WDYT?

I think I'd prefer this to be in a repo separate from android_tools, which seems
limited to the SDK & NDK. I don't think that repo would necessarily have to be
limited to just this APK, though it would start that way.

I can't say I'd be an OWNER of android_tools if it had an OWNERS file, though.

Powered by Google App Engine
This is Rietveld 408576698