Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5192)

Unified Diff: chrome/browser/profiles/off_the_record_profile_impl_unittest.cc

Issue 11866004: Add scheme to HostZoomMap (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix alignment, add comment Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/off_the_record_profile_impl_unittest.cc
diff --git a/chrome/browser/profiles/off_the_record_profile_impl_unittest.cc b/chrome/browser/profiles/off_the_record_profile_impl_unittest.cc
index 3140e32c2a40d4675b4a931940f1deacc02eebed..ad2e21b192e31fc497471545d0eb72665dd852cd 100644
--- a/chrome/browser/profiles/off_the_record_profile_impl_unittest.cc
+++ b/chrome/browser/profiles/off_the_record_profile_impl_unittest.cc
@@ -52,7 +52,7 @@ class TestingProfileWithHostZoomMap : public TestingProfile {
return;
HostZoomMap* host_zoom_map = HostZoomMap::GetForBrowserContext(this);
- double level = host_zoom_map->GetZoomLevel(host);
+ double level = host_zoom_map->GetZoomLevelForHost(host);
DictionaryPrefUpdate update(prefs_.get(), prefs::kPerHostZoomLevels);
DictionaryValue* host_zoom_dictionary = update.Get();
if (level == host_zoom_map->GetDefaultZoomLevel()) {
@@ -131,8 +131,8 @@ TEST_F(OffTheRecordProfileImplTest, GetHostZoomMap) {
HostZoomMap::GetForBrowserContext(parent_profile.get());
ASSERT_TRUE(parent_zoom_map);
- parent_zoom_map->SetZoomLevel(host, zoom_level_25);
- ASSERT_EQ(parent_zoom_map->GetZoomLevel(host), zoom_level_25);
+ parent_zoom_map->SetZoomLevelForHost(host, zoom_level_25);
+ ASSERT_EQ(parent_zoom_map->GetZoomLevelForHost(host), zoom_level_25);
// TODO(yosin) We need to wait ProfileImpl::Observe done for
// OnZoomLevelChanged.
@@ -153,21 +153,21 @@ TEST_F(OffTheRecordProfileImplTest, GetHostZoomMap) {
// Verity.
EXPECT_NE(parent_zoom_map, child_zoom_map);
- EXPECT_EQ(parent_zoom_map->GetZoomLevel(host),
- child_zoom_map->GetZoomLevel(host)) <<
+ EXPECT_EQ(parent_zoom_map->GetZoomLevelForHost(host),
+ child_zoom_map->GetZoomLevelForHost(host)) <<
"Child must inherit from parent.";
- child_zoom_map->SetZoomLevel(host, zoom_level_30);
- ASSERT_EQ(child_zoom_map->GetZoomLevel(host), zoom_level_30);
+ child_zoom_map->SetZoomLevelForHost(host, zoom_level_30);
+ ASSERT_EQ(child_zoom_map->GetZoomLevelForHost(host), zoom_level_30);
- EXPECT_NE(parent_zoom_map->GetZoomLevel(host),
- child_zoom_map->GetZoomLevel(host)) <<
+ EXPECT_NE(parent_zoom_map->GetZoomLevelForHost(host),
+ child_zoom_map->GetZoomLevelForHost(host)) <<
"Child change must not propagate to parent.";
- parent_zoom_map->SetZoomLevel(host, zoom_level_40);
- ASSERT_EQ(parent_zoom_map->GetZoomLevel(host), zoom_level_40);
+ parent_zoom_map->SetZoomLevelForHost(host, zoom_level_40);
+ ASSERT_EQ(parent_zoom_map->GetZoomLevelForHost(host), zoom_level_40);
- EXPECT_EQ(parent_zoom_map->GetZoomLevel(host),
- child_zoom_map->GetZoomLevel(host)) <<
+ EXPECT_EQ(parent_zoom_map->GetZoomLevelForHost(host),
+ child_zoom_map->GetZoomLevelForHost(host)) <<
"Parent change should propagate to child.";
}

Powered by Google App Engine
This is Rietveld 408576698