Add scheme to HostZoomMap

content/public/browser/host_zoom_map.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_HOST_ZOOM_MAP_H_
 #define CONTENT_PUBLIC_BROWSER_HOST_ZOOM_MAP_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 21 matching lines @@
   // Returns the zoom level for the host or spec for a given url. The zoom
   // level is determined by the host portion of the URL, or (in the absence of
   // a host) the complete spec of the URL. In most cases, there is no custom
   // zoom level, and this returns the user's default zoom level.  Otherwise,
   // returns the saved zoom level, which may be positive (to zoom in) or
   // negative (to zoom out).
   //
   // This may be called on any thread.
   virtual double GetZoomLevel(const std::string& host) const = 0;
 
+  // Returns the zoom level for the host or spec for a given url, taking scheme

[Nikita (slow), 2013/01/11 15:23:55]

nit: |scheme| |host|

[Denis Kuznetsov (DE-MUC), 2013/01/11 15:48:59]

Done.

+  // in account. If there is specific zoom level specified for given host and
+  // scheme pair, it will be returned. In other cases result is equivalent to
+  // GetZoomLevel(host).
+  //
+  // This may be called on any thread.
+  virtual double GetZoomLevel(const std::string& scheme,

[Nikita (slow), 2013/01/11 15:23:55]

Maybe name this GetZoomLevelBySchemeHost ?

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Overl...

[Denis Kuznetsov (DE-MUC), 2013/01/11 15:48:59]

I would prefer to rename or remove old method, as it is now useless, however,
that would be much more incompatible API change.

[Nikita (slow), 2013/01/11 15:50:39]

I agree that this seems like a better option.

+                              const std::string& host) const = 0;
+
   // Sets the zoom level for the host or spec for a given url to |level|.  If
   // the level matches the current default zoom level, the host is erased
   // from the saved preferences; otherwise the new value is written out.
   //
   // This should only be called on the UI thread.
   virtual void SetZoomLevel(const std::string& host, double level) = 0;
 
+  // Sets the zoom level for the host/scheme pair to |level|.
+  //
+  // This should only be called on the UI thread.
+  virtual void SetZoomLevel(const std::string& scheme,
+                            const std::string& host,
+                            double level) = 0;
+
   // Get/Set the default zoom level for pages that don't override it.
   virtual double GetDefaultZoomLevel() const = 0;
   virtual void SetDefaultZoomLevel(double level) = 0;;
 
  protected:
   virtual ~HostZoomMap() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_HOST_ZOOM_MAP_H_