Add base class cr.ui.BubbleButton for options.ControlledSettingIndicator

Add base class cr.ui.BubbleButton for options.ControlledSettingIndicator

This CL extracts a cr.ui.BubbleButton base class from the
options.ControlledSettingIndicator so that it can be shared with the
upcoming improved about:policy page.

BUG=134849
TEST=Manual


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176910

[bartfab (slow), 2013-01-11 17:53:08]

Hi James,

Could you please review?

[James Hawkins, 2013-01-11 18:49:22]

LGTM with nit.

https://codereview.chromium.org/11864019/diff/1/chrome/browser/resources/shar...
File chrome/browser/resources/shared/css/bubble_button.css (right):

https://codereview.chromium.org/11864019/diff/1/chrome/browser/resources/shar...
chrome/browser/resources/shared/css/bubble_button.css:3: * found in the LICENSE
file. */
nit: Final */ should be on the next line.

[bartfab (slow), 2013-01-11 19:45:56]

https://chromiumcodereview.appspot.com/11864019/diff/1/chrome/browser/resourc...
File chrome/browser/resources/shared/css/bubble_button.css (right):

https://chromiumcodereview.appspot.com/11864019/diff/1/chrome/browser/resourc...
chrome/browser/resources/shared/css/bubble_button.css:3: * found in the LICENSE
file. */
On 2013/01/11 18:49:22, James Hawkins wrote:
> nit: Final */ should be on the next line.

Done. Interestingly, all other CSS and JS files I checked also had the trailing
*/ in their license headers.

[James Hawkins, 2013-01-11 19:48:47]

:-)

https://chromiumcodereview.appspot.com/11864019/diff/1/chrome/browser/resourc...
File chrome/browser/resources/shared/css/bubble_button.css (right):

https://chromiumcodereview.appspot.com/11864019/diff/1/chrome/browser/resourc...
chrome/browser/resources/shared/css/bubble_button.css:3: * found in the LICENSE
file. */
On 2013/01/11 19:45:56, bartfab wrote:
> On 2013/01/11 18:49:22, James Hawkins wrote:
> > nit: Final */ should be on the next line.
> 
> Done. Interestingly, all other CSS and JS files I checked also had the
trailing
> */ in their license headers.

I step away for 8 months and...

[Dan Beam, 2013-01-11 20:32:10]

https://chromiumcodereview.appspot.com/11864019/diff/1/chrome/browser/resourc...
File chrome/browser/resources/shared/css/bubble_button.css (right):

https://chromiumcodereview.appspot.com/11864019/diff/1/chrome/browser/resourc...
chrome/browser/resources/shared/css/bubble_button.css:3: * found in the LICENSE
file. */
On 2013/01/11 19:45:56, bartfab wrote:
> On 2013/01/11 18:49:22, James Hawkins wrote:
> > nit: Final */ should be on the next line.
> 
> Done. Interestingly, all other CSS and JS files I checked also had the
trailing
> */ in their license headers.

This is not specified anywhere and the last I remember we weren't suggesting
either way, right?

[commit-bot: I haz the power, 2013-01-15 13:46:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/11864019/2002

[commit-bot: I haz the power, 2013-01-15 16:08:42]

Change committed as 176910