Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: src/hydrogen.cc

Issue 11864013: Make HCheckPrototypeMaps compatible with parallel recompilation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comment Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index a4578ee3dfa5324e94cdd9ae32c2b08ffd9b7852..10b0a9776c6449260a3244077636a36fccdd9d3c 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -5560,7 +5560,8 @@ HInstruction* HOptimizedGraphBuilder::BuildStoreNamedField(
ASSERT(proto->IsJSObject());
AddInstruction(new(zone()) HCheckPrototypeMaps(
Handle<JSObject>(JSObject::cast(map->prototype())),
- Handle<JSObject>(JSObject::cast(proto))));
+ Handle<JSObject>(JSObject::cast(proto)),
+ zone()));
}
int index = ComputeLoadStoreFieldIndex(map, name, lookup);
@@ -6295,8 +6296,8 @@ HInstruction* HOptimizedGraphBuilder::BuildLoadNamedMonomorphic(
Handle<JSObject> holder(lookup.holder());
Handle<Map> holder_map(holder->map());
AddCheckMapsWithTransitions(object, map);
- HInstruction* holder_value =
- AddInstruction(new(zone()) HCheckPrototypeMaps(prototype, holder));
+ HInstruction* holder_value = AddInstruction(
+ new(zone()) HCheckPrototypeMaps(prototype, holder, zone()));
return BuildLoadNamedField(holder_value, holder_map, &lookup);
}
@@ -6835,8 +6836,9 @@ void HOptimizedGraphBuilder::VisitProperty(Property* expr) {
void HOptimizedGraphBuilder::AddCheckPrototypeMaps(Handle<JSObject> holder,
Handle<Map> receiver_map) {
if (!holder.is_null()) {
- AddInstruction(new(zone()) HCheckPrototypeMaps(
- Handle<JSObject>(JSObject::cast(receiver_map->prototype())), holder));
+ Handle<JSObject> prototype(JSObject::cast(receiver_map->prototype()));
+ AddInstruction(
+ new(zone()) HCheckPrototypeMaps(prototype, holder, zone()));
}
}
@@ -7468,7 +7470,8 @@ bool HOptimizedGraphBuilder::TryInlineBuiltinMethodCall(
ASSERT(!expr->holder().is_null());
AddInstruction(new(zone()) HCheckPrototypeMaps(
oracle()->GetPrototypeForPrimitiveCheck(STRING_CHECK),
- expr->holder()));
+ expr->holder(),
+ zone()));
HStringCharCodeAt* char_code =
BuildStringCharCodeAt(context, string, index);
if (id == kStringCharCodeAt) {
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698