Issue 11864004: Findbugs issues

Issue 11864004: Findbugs issues (Closed)

Created:
7 years, 11 months ago by Kristian Monsen

Modified:
7 years, 11 months ago

Reviewers:
Ted C, mnaganov (inactive), mnaganov

CC:
chromium-reviews, android-webview-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Findbugs issues A test case with setUp() or tearDown() should call the super method BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176597

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved super.tearDown to the end #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	build/android/findbugs_filter/findbugs_known_bugs.txt	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderBookmarkNodeTest.java	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

LGTM % comment Thanks for fixing these! https://codereview.chromium.org/11864004/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java File android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java (right): https://codereview.chromium.org/11864004/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java#newcode28 android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java:28: super.tearDown(); I ...

7 years, 11 months ago (2013-01-11 09:28:49 UTC) #2

Kristian Monsen

https://codereview.chromium.org/11864004/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java File android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java (right): https://codereview.chromium.org/11864004/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java#newcode28 android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java:28: super.tearDown(); On 2013/01/11 09:28:49, Mikhail Naganov (Chromium) wrote: > ...

7 years, 11 months ago (2013-01-11 19:28:31 UTC) #4