Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 11861018: Reenable IPCSyncChannelTest.SendWithTimeoutMixedOKAndTimeout (Closed)

Created:
7 years, 11 months ago by viettrungluu
Modified:
7 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Reenable IPCSyncChannelTest.SendWithTimeoutMixedOKAndTimeout This is speculative: I fixed crbug.com/25841, and hope that that's the underlying cause for crbug.com/70075 (flakiness on Windows). Or maybe the cause was something else that has also since gone away (since the test was reliable for a long time before). BUG=70075 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M ipc/ipc_sync_channel_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
7 years, 11 months ago (2013-01-11 20:20:23 UTC) #1
jam
lgtm
7 years, 11 months ago (2013-01-11 21:35:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11861018/1
7 years, 11 months ago (2013-01-11 22:34:53 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-12 19:35:28 UTC) #4
Message was sent while issue was closed.
Change committed as 176578

Powered by Google App Engine
This is Rietveld 408576698