Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 11860012: Android: capture logcat for all devices on bb_run_sharded_steps.py (Closed)

Created:
7 years, 11 months ago by bulach
Modified:
7 years, 11 months ago
Reviewers:
tonyg, Isaac (away)
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android: capture logcat for all devices on bb_run_sharded_steps.py This will help track issues when running sharded steps, specially the perf ones. BUG=165692 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176754

Patch Set 1 : Patch #

Total comments: 2

Patch Set 2 : import order #

Total comments: 2

Patch Set 3 : Don't kill monitor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M build/android/bb_run_sharded_steps.py View 1 2 3 chunks +28 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
bulach
ptal
7 years, 11 months ago (2013-01-11 16:44:38 UTC) #1
tonyg
On 2013/01/11 16:44:38, bulach wrote: > ptal lgtm
7 years, 11 months ago (2013-01-11 16:54:20 UTC) #2
tonyg
I meant lgtm with nit. https://codereview.chromium.org/11860012/diff/4001/build/android/bb_run_sharded_steps.py File build/android/bb_run_sharded_steps.py (right): https://codereview.chromium.org/11860012/diff/4001/build/android/bb_run_sharded_steps.py#newcode47 build/android/bb_run_sharded_steps.py:47: import subprocess nit: alphabetize ...
7 years, 11 months ago (2013-01-11 16:54:44 UTC) #3
bulach
thanks tony! done. https://codereview.chromium.org/11860012/diff/4001/build/android/bb_run_sharded_steps.py File build/android/bb_run_sharded_steps.py (right): https://codereview.chromium.org/11860012/diff/4001/build/android/bb_run_sharded_steps.py#newcode47 build/android/bb_run_sharded_steps.py:47: import subprocess On 2013/01/11 16:54:44, tonyg ...
7 years, 11 months ago (2013-01-11 17:36:26 UTC) #4
Isaac (away)
Lgtm with a minor nit. Cool use of enter and exit btw. https://codereview.chromium.org/11860012/diff/5002/build/android/bb_run_sharded_steps.py File build/android/bb_run_sharded_steps.py ...
7 years, 11 months ago (2013-01-11 21:46:36 UTC) #5
bulach
thanks! comment addressed, CQing https://codereview.chromium.org/11860012/diff/5002/build/android/bb_run_sharded_steps.py File build/android/bb_run_sharded_steps.py (right): https://codereview.chromium.org/11860012/diff/5002/build/android/bb_run_sharded_steps.py#newcode101 build/android/bb_run_sharded_steps.py:101: self._monitor.terminate() On 2013/01/11 21:46:36, Isaac ...
7 years, 11 months ago (2013-01-14 09:14:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11860012/11001
7 years, 11 months ago (2013-01-14 10:05:56 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
7 years, 11 months ago (2013-01-14 11:43:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11860012/11001
7 years, 11 months ago (2013-01-14 11:50:30 UTC) #9
commit-bot: I haz the power
Presubmit check for 11860012-11001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-14 11:50:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11860012/11001
7 years, 11 months ago (2013-01-14 12:47:28 UTC) #11
commit-bot: I haz the power
Presubmit check for 11860012-11001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-14 12:47:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11860012/11001
7 years, 11 months ago (2013-01-14 14:34:35 UTC) #13
commit-bot: I haz the power
Presubmit check for 11860012-11001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-14 14:34:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11860012/11001
7 years, 11 months ago (2013-01-14 22:12:00 UTC) #15
commit-bot: I haz the power
Change committed as 176754
7 years, 11 months ago (2013-01-14 23:23:36 UTC) #16
Isaac (away)
Actually, thinking more about this, is there a reason we can't have bots go through ...
7 years, 11 months ago (2013-01-20 01:44:42 UTC) #17
bulach
7 years, 11 months ago (2013-01-21 17:01:58 UTC) #18
Message was sent while issue was closed.
that's actually a good suggestion :)
in fact, this approach didn't work, as the stack symbolization would happen
before the logs were actually saved (specially downstream).. let me clean this
up and fix this, will send new patches shortly.

Powered by Google App Engine
This is Rietveld 408576698