Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 11860005: Findbugs fixes, removing fields that are never read from (Closed)

Created:
7 years, 11 months ago by Kristian Monsen
Modified:
7 years, 11 months ago
Reviewers:
nilesh
CC:
chromium-reviews, jam, ilevy+watch_chromium.org, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, darin-cc_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Findbugs fixes, removing fields that are never read from BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176625

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -25 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 5 chunks +4 lines, -11 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/HandleView.java View 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nilesh
LGTM
7 years, 11 months ago (2013-01-11 15:53:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/11860005/1
7 years, 11 months ago (2013-01-11 18:49:22 UTC) #2
commit-bot: I haz the power
Failed to apply patch for build/android/findbugs_filter/findbugs_known_bugs.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 11 months ago (2013-01-11 18:49:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/11860005/6001
7 years, 11 months ago (2013-01-11 21:07:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/11860005/18002
7 years, 11 months ago (2013-01-13 08:28:20 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-14 01:19:33 UTC) #6
Message was sent while issue was closed.
Change committed as 176625

Powered by Google App Engine
This is Rietveld 408576698