Issue 11859027: Temporarily disable deferred stack trace formatting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11859027: Temporarily disable deferred stack trace formatting. (Closed)

Created:
7 years, 11 months ago by Yang

Modified:
7 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Temporarily disable deferred stack trace formatting. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13431

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
M	src/heap.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/isolate.cc	View		1 chunk	+0 lines, -1 line	1 comment	Download
M	test/cctest/cctest.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 11 months ago (2013-01-18 12:28:39 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/11859027/diff/3001/src/isolate.cc
File src/isolate.cc (left):

https://chromiumcodereview.appspot.com/11859027/diff/3001/src/isolate.cc#oldc...
src/isolate.cc:638: heap()->error_object_list()->Add(*error_object);
Would it make sense to have a flag for that?

Expand Messages | Collapse Messages