Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 11857022: Bubble CSS: Replace relative positioning trickery with a margin (Closed)

Created:
7 years, 11 months ago by bartfab (slow)
Modified:
7 years, 11 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Bubble CSS: Replace relative positioning trickery with a margin The bubble contents is supposed to be inset 1px from the bubble border. This can be achieved by setting a 1px margin on the content. No need for any relative positioning trickery. BUG=134849 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/resources/shared/css/bubble.css View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bartfab (slow)
Hi James, Could you please review?
7 years, 11 months ago (2013-01-11 19:45:06 UTC) #1
James Hawkins
lgtm
7 years, 11 months ago (2013-01-11 19:48:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11857022/1
7 years, 11 months ago (2013-01-15 16:20:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11857022/1
7 years, 11 months ago (2013-01-15 20:06:52 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-15 21:23:19 UTC) #5
Message was sent while issue was closed.
Change committed as 176973

Powered by Google App Engine
This is Rietveld 408576698