Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 11857015: Remove move ascii data hint for one byte strings (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3381 matching lines...) Expand 10 before | Expand all | Expand 10 after
3392 } 3392 }
3393 3393
3394 3394
3395 void MacroAssembler::JumpIfBothInstanceTypesAreNotSequentialAscii( 3395 void MacroAssembler::JumpIfBothInstanceTypesAreNotSequentialAscii(
3396 Register first, 3396 Register first,
3397 Register second, 3397 Register second,
3398 Register scratch1, 3398 Register scratch1,
3399 Register scratch2, 3399 Register scratch2,
3400 Label* failure) { 3400 Label* failure) {
3401 int kFlatAsciiStringMask = 3401 int kFlatAsciiStringMask =
3402 kIsNotStringMask | kStringEncodingMask | kAsciiDataHintMask | 3402 kIsNotStringMask | kStringEncodingMask | kStringRepresentationMask;
3403 kStringRepresentationMask;
3404 int kFlatAsciiStringTag = ASCII_STRING_TYPE; 3403 int kFlatAsciiStringTag = ASCII_STRING_TYPE;
3405 ASSERT_EQ(ASCII_STRING_TYPE, ASCII_STRING_TYPE & kFlatAsciiStringMask);
3406 and_(scratch1, first, Operand(kFlatAsciiStringMask)); 3404 and_(scratch1, first, Operand(kFlatAsciiStringMask));
3407 and_(scratch2, second, Operand(kFlatAsciiStringMask)); 3405 and_(scratch2, second, Operand(kFlatAsciiStringMask));
3408 cmp(scratch1, Operand(kFlatAsciiStringTag)); 3406 cmp(scratch1, Operand(kFlatAsciiStringTag));
3409 // Ignore second test if first test failed. 3407 // Ignore second test if first test failed.
3410 cmp(scratch2, Operand(kFlatAsciiStringTag), eq); 3408 cmp(scratch2, Operand(kFlatAsciiStringTag), eq);
3411 b(ne, failure); 3409 b(ne, failure);
3412 } 3410 }
3413 3411
3414 3412
3415 void MacroAssembler::JumpIfInstanceTypeIsNotSequentialAscii(Register type, 3413 void MacroAssembler::JumpIfInstanceTypeIsNotSequentialAscii(Register type,
3416 Register scratch, 3414 Register scratch,
3417 Label* failure) { 3415 Label* failure) {
3418 int kFlatAsciiStringMask = 3416 int kFlatAsciiStringMask =
3419 kIsNotStringMask | kStringEncodingMask | kAsciiDataHintMask | 3417 kIsNotStringMask | kStringEncodingMask | kStringRepresentationMask;
3420 kStringRepresentationMask;
3421 int kFlatAsciiStringTag = ASCII_STRING_TYPE; 3418 int kFlatAsciiStringTag = ASCII_STRING_TYPE;
3422 ASSERT_EQ(ASCII_STRING_TYPE, ASCII_STRING_TYPE & kFlatAsciiStringMask);
3423 and_(scratch, type, Operand(kFlatAsciiStringMask)); 3419 and_(scratch, type, Operand(kFlatAsciiStringMask));
3424 cmp(scratch, Operand(kFlatAsciiStringTag)); 3420 cmp(scratch, Operand(kFlatAsciiStringTag));
3425 b(ne, failure); 3421 b(ne, failure);
3426 } 3422 }
3427 3423
3428 static const int kRegisterPassedArguments = 4; 3424 static const int kRegisterPassedArguments = 4;
3429 3425
3430 3426
3431 int MacroAssembler::CalculateStackPassedWords(int num_reg_arguments, 3427 int MacroAssembler::CalculateStackPassedWords(int num_reg_arguments,
3432 int num_double_arguments) { 3428 int num_double_arguments) {
(...skipping 532 matching lines...) Expand 10 before | Expand all | Expand 10 after
3965 void CodePatcher::EmitCondition(Condition cond) { 3961 void CodePatcher::EmitCondition(Condition cond) {
3966 Instr instr = Assembler::instr_at(masm_.pc_); 3962 Instr instr = Assembler::instr_at(masm_.pc_);
3967 instr = (instr & ~kCondMask) | cond; 3963 instr = (instr & ~kCondMask) | cond;
3968 masm_.emit(instr); 3964 masm_.emit(instr);
3969 } 3965 }
3970 3966
3971 3967
3972 } } // namespace v8::internal 3968 } } // namespace v8::internal
3973 3969
3974 #endif // V8_TARGET_ARCH_ARM 3970 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698