Issue 11854012: Rename options.OptionsBubble to cr.ui.AutoCloseBubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11854012: Rename options.OptionsBubble to cr.ui.AutoCloseBubble (Closed)

Created:
7 years, 11 months ago by bartfab (slow)

Modified:
7 years, 11 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename options.OptionsBubble to cr.ui.AutoCloseBubble This CL makes the bubble implementation used on the options page into the cr.ui namespace so that it can be shared with the upcoming improved about:policy page. BUG=134849 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176821

Patch Set 1 #

Patch Set 2 : Remove obsoleted CSS declaration. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -123 lines)			Patch
D	chrome/browser/resources/options/options_bubble.js	View		1 chunk	+0 lines, -112 lines	0 comments	Download
M	chrome/browser/resources/options/options_bundle.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/options_page.css	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/options/options_page.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/shared/css/bubble.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/bubble.js	View		2 chunks	+110 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/11854012/3001

7 years, 11 months ago (2013-01-14 21:17:45 UTC) #3

Message was sent while issue was closed.

Change committed as 176821

Expand Messages | Collapse Messages