Improved test coverage of login_utils_browsertest.cc.

Improved test coverage of login_utils_browsertest.cc.

Calling LoginUtils::CompleteProfileCreate() directly makes the tests pass always, even if the login sequence is broken.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176376

[Joao da Silva, 2013-01-11 12:25:50]

This is just the fix for login_utils_browsertest.cc, without the changes to the
enterprise login behavior.

Please have a look, thanks!

https://codereview.chromium.org/11853012/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/login_utils_browsertest.cc (right):

https://codereview.chromium.org/11853012/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/login_utils_browsertest.cc:407: const bool
kHasCookies = false;
This prevents the UI->IO->UI jump at ProfileAuthData::Transfer(), and makes the
OnProfileCreated() delegate calls unnecessary. Those calls were introduced in
https://chromiumcodereview.appspot.com/11576065/ to fix this test.

Calling LoginUtils::CompleteProfileCreate() directly from the test makes the
subsequent checks always pass, so if something breaks in the
profile-creation-unlocking logic then this test wouldn't catch it.

[Nikita (slow), 2013-01-11 13:05:20]

lgtm

[commit-bot: I haz the power, 2013-01-11 15:44:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/11853012/1

[commit-bot: I haz the power, 2013-01-11 16:58:40]

Change committed as 176376