Issue 11852019: Prepare API for webkit use of Latin-1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11852019: Prepare API for webkit use of Latin-1 (Closed)

Created:
7 years, 11 months ago by drcarney

Modified:
7 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare API for webkit use of Latin-1 R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13369

Patch Set 1 #

Patch Set 2 : prepared a couple more name changes #

Patch Set 3 : Changed mind #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -23 lines)			Patch
	M	include/v8.h	View	1 2	4 chunks	+14 lines, -1 line	0 comments	Download
	M	src/api.cc	View		2 chunks	+51 lines, -22 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Yang

7 years, 11 months ago (2013-01-14 11:21:38 UTC) #1

LGTM save for one small detail that I fixed. Landing.

https://codereview.chromium.org/11852019/diff/4001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/11852019/diff/4001/src/api.cc#newcode3898
src/api.cc:3898: if (IsDeadCheck(str->GetIsolate(),
"v8::String::MayContainNonAscii()")) {
This should reflect the method name since this string is for debugging purposes.
Fixed that for you.

Expand Messages | Collapse Messages