Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1185193006: Fixed presubmit (Closed)

Created:
5 years, 6 months ago by pgervais
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/masters_recipes_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
pgervais
Fixes the current build/ presubmit breakage, ptal.
5 years, 6 months ago (2015-06-15 22:43:53 UTC) #2
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-15 22:51:35 UTC) #4
smut
lgtm
5 years, 6 months ago (2015-06-15 22:56:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185193006/1
5 years, 6 months ago (2015-06-15 23:04:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295689
5 years, 6 months ago (2015-06-15 23:08:16 UTC) #8
Adrian Kuegel
Thanks for fixing this. I wonder why my CL passed the presubmit tests. I just ...
5 years, 6 months ago (2015-06-16 08:06:25 UTC) #10
Adrian Kuegel
5 years, 6 months ago (2015-06-16 08:12:52 UTC) #11
Message was sent while issue was closed.
On 2015/06/16 08:06:25, Adrian Kuegel wrote:
> Thanks for fixing this. I wonder why my CL passed the presubmit tests. I just
> checked that the test is executed in the correct directory on the presubmit
bot:
> cwd=/b/build/slave/presubmit_build/build/build
> And I have set the environment to exclude the path to the other build
checkout.

Ok, apparently the pyc file was still around, so the test didn't fail. We need
to remove the pyc files when running the presubmit tests.
Filed crbug.com/500841

Powered by Google App Engine
This is Rietveld 408576698