Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 11841008: Telemetry: fixes SurfaceStatsCollector usage. (Closed)

Created:
7 years, 11 months ago by bulach
Modified:
7 years, 11 months ago
Reviewers:
nduca, Sami
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

Telemetry: fixes SurfaceStatsCollector usage. The "activity" string was being wrongly created, fully qualify them all. BUG=165914 TEST=tools/perf/run_multipage_benchmarks -v --browser=android-chrome scrolling_benchmark tools/perf/page_sets/top_25.json Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/telemetry/telemetry/android_browser_finder.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bulach
there's a bigger change here: https://codereview.chromium.org/11428107/ but this seems harmless enough to get in..
7 years, 11 months ago (2013-01-15 16:16:38 UTC) #1
Sami
lgtm
7 years, 11 months ago (2013-01-15 16:42:22 UTC) #2
nduca
lgtm, whomp
7 years, 11 months ago (2013-01-16 02:57:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11841008/1
7 years, 11 months ago (2013-01-16 09:42:40 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 13:11:21 UTC) #5
Message was sent while issue was closed.
Change committed as 177138

Powered by Google App Engine
This is Rietveld 408576698