Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: content/components/README

Issue 11830043: Move content/components/navigation_interception to src/components (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/components/OWNERS ('k') | content/components/navigation_interception/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 =============== BLINK BLINK BLINK ===============
2 =============== BLINK BLINK BLINK ===============
3
4 Warning: The decision has been made that the new home for components
5 that depend on the Content Module and layers below it is
6 src/components/. Full details at
7 http://www.chromium.org/developers/design-documents/browser-components
8
9 The components currently in src/content/components/
10 (this directory) will be moving there. Talk to joi@chromium.org for
11 coordination if you are creating a new component.
12
13 =============== BLINK BLINK BLINK ===============
14 =============== BLINK BLINK BLINK ===============
15
16
17 This directory is for components that have the Content Module as the
18 uppermost layer they depend on. They may depend only on the Content
19 API (content/public) and on lower layers (e.g. base/, net/, ipc/
20 etc.).
21
22 These components are not part of the Content Module itself. They are
23 built in a separate .gyp file (content_components.gyp in this
24 directory).
25
26 Components that have bits of code that need to live in different
27 processes (e.g. some code in the browser process, some in the renderer
28 process, etc.) should separate the code into different subdirectories.
29 Hence for a component named 'foo' you might end up with a structure
30 like the following:
31
32 content/components/foo - DEPS, OWNERS, foo.gypi
33 content/components/foo/browser - code that needs the browser process
34 content/components/foo/common - for e.g. IPC constants and such
35 content/components/foo/renderer - code that needs renderer process
36
37 These subdirectories should have DEPS files with the relevant
38 restrictions in place, e.g. only content/components/foo/browser should
39 be allowed to #include from content/public/browser.
40
41 Note that there may also be an 'android' subdir, with a Java source
42 code structure underneath it where the package name is
43 org.chromium.content.component.foo, and with subdirs after 'foo'
44 to illustrate process, e.g. 'browser' or 'renderer':
45
46 content/components/foo/android/OWNERS, DEPS
47 content/components/foo/android/java/src/org/chromium/content/component/foo/brows er/
48 content/components/foo/android/javatests/src/org/chromium/content/component/foo/ browser/
49
50 Code in content/components/ should be placed in the content:: namespace.
OLDNEW
« no previous file with comments | « content/components/OWNERS ('k') | content/components/navigation_interception/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698