Make all net targets build on Win64

Make all net targets build on Win64

BUG=166496
BUG=167187
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176200

[jschuh, 2013-01-10 00:02:09]

This is just to eliminate win64 compile errors. We'll have to sweep through
later and fix what's causing the warnings.

cbentzel - for net
pastarmovj - for policy

[pastarmovj, 2013-01-10 09:08:47]

lgtm

[cbentzel, 2013-01-10 17:31:03]

Adding rch for the SPDY change. This code is shared (albeit not directly) with
some non-Chrome binaries.

https://codereview.chromium.org/11830032/diff/5001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/11830032/diff/5001/net/net.gyp#newcode1171
net/net.gyp:1171: 'msvs_disabled_warnings': [4267, ],
Can you provide a list of lines where compiler failed with this warning?

[cbentzel, 2013-01-10 17:31:27]

-rch@google.com,+rch@chromium.org

[jschuh, 2013-01-10 17:39:42]

https://codereview.chromium.org/11830032/diff/5001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/11830032/diff/5001/net/net.gyp#newcode1171
net/net.gyp:1171: 'msvs_disabled_warnings': [4267, ],
On 2013/01/10 17:31:03, cbentzel wrote:
> Can you provide a list of lines where compiler failed with this warning?

Not practically speaking, because it's a massive list. Sadly, the Google C++
style guide encourages a pattern that's hostile to proper use of size_t and
ptrdiff_t, so we have a slew of these compilation warnings (and simply ignore
them on other 64-bit platforms).

[Ryan Hamilton, 2013-01-10 17:46:06]

https://codereview.chromium.org/11830032/diff/5001/net/spdy/spdy_framer.h
File net/spdy/spdy_framer.h (right):

https://codereview.chromium.org/11830032/diff/5001/net/spdy/spdy_framer.h#new...
net/spdy/spdy_framer.h:71: typedef std::pair<SpdySettingsFlags, size_t>
SettingsFlagsAndValue;
I don't believe that this change is correct.  The value field for a SPDY setting
on the wire is a uint32.  I don't think we want to use size_t here which would
make it 64 bits on some platforms.  It's possible that this might not introduce
any *bugs*, but it does't feel "right" to me.

[jschuh, 2013-01-10 17:49:32]

https://codereview.chromium.org/11830032/diff/5001/net/spdy/spdy_framer.h
File net/spdy/spdy_framer.h (right):

https://codereview.chromium.org/11830032/diff/5001/net/spdy/spdy_framer.h#new...
net/spdy/spdy_framer.h:71: typedef std::pair<SpdySettingsFlags, size_t>
SettingsFlagsAndValue;
On 2013/01/10 17:46:06, Ryan Hamilton wrote:
> I don't believe that this change is correct.  The value field for a SPDY
setting
> on the wire is a uint32.  I don't think we want to use size_t here which would
> make it 64 bits on some platforms.  It's possible that this might not
introduce
> any *bugs*, but it does't feel "right" to me.

Gotcha, I traced it through and I thought this one was safe, but I guess I
didn't go far enough. I'll revert this and probably just do explicit casts at
the callers in the test code, since I know all those are safe and it's the only
way to prevent template error spew.

[jschuh, 2013-01-10 18:56:01]

@rch - How about this?

[Ryan Hamilton, 2013-01-10 19:31:07]

On 2013/01/10 18:56:01, Justin Schuh wrote:
> @rch - How about this?

LGTM.  Thanks!  I'm sorry to make you do this.  If there are instructions about
how to fix these errors, I'd be happy to do it myself...

[jschuh, 2013-01-10 20:27:39]

On 2013/01/10 19:31:07, Ryan Hamilton wrote:
> On 2013/01/10 18:56:01, Justin Schuh wrote:
> > @rch - How about this?
> 
> LGTM.  Thanks!  I'm sorry to make you do this.  If there are instructions
about
> how to fix these errors, I'd be happy to do it myself...

@rch - It's mostly dependency stuff, since by necessity the net code tends to
use fully specified types. But I will take you up on the offer when we circle
back to remove the warnings.

@cbentzel - Is Ryan's sign off good for you?

[cbentzel, 2013-01-10 20:46:36]

Yes, LGTM

On Thu, Jan 10, 2013 at 3:27 PM, <jschuh@chromium.org> wrote:

> @cbentzel - Is Ryan's sign off good for you?

[commit-bot: I haz the power, 2013-01-10 20:47:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/11830032/3006

[commit-bot: I haz the power, 2013-01-10 23:24:29]

Change committed as 176200