Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 11830020: [content shell] when the test contains the path loading/ enable frame load callback dumping (Closed)

Created:
7 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 11 months ago
Reviewers:
marja
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] when the test contains the path loading/ enable frame load callback dumping Also, don't mark a test as finished until the top frame stopped loading. BUG=111316 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M content/shell/webkit_test_runner.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/webkit_test_runner.cc View 5 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 11 months ago (2013-01-09 16:24:33 UTC) #1
marja
lgtm
7 years, 11 months ago (2013-01-09 19:32:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11830020/1
7 years, 11 months ago (2013-01-09 19:51:32 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 21:42:51 UTC) #4
Message was sent while issue was closed.
Change committed as 175893

Powered by Google App Engine
This is Rietveld 408576698