Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: chrome/browser/history/history_backend.h

Issue 11830007: Avoid sending notifications when the bitmap data in history has not changed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Split the changes to MergeFavicon() and SetFavicons() into two CLs as only the changes to MergeFavi… Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/memory/ref_counted_memory_unittest.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 686 matching lines...) Expand 10 before | Expand all | Expand 10 after
697 const IconURLSizesMap& icon_url_sizes) const; 697 const IconURLSizesMap& icon_url_sizes) const;
698 698
699 // Sets the sizes that the thumbnail database knows that the favicon at 699 // Sets the sizes that the thumbnail database knows that the favicon at
700 // |icon_id| is available from the web. See history_types.h for a more 700 // |icon_id| is available from the web. See history_types.h for a more
701 // detailed description of FaviconSizes. 701 // detailed description of FaviconSizes.
702 // Deletes any favicon bitmaps currently mapped to |icon_id| whose pixel 702 // Deletes any favicon bitmaps currently mapped to |icon_id| whose pixel
703 // sizes are not contained in |favicon_sizes|. 703 // sizes are not contained in |favicon_sizes|.
704 void SetFaviconSizes(FaviconID icon_id, 704 void SetFaviconSizes(FaviconID icon_id,
705 const FaviconSizes& favicon_sizes); 705 const FaviconSizes& favicon_sizes);
706 706
707 // Returns true if the bitmap data at |bitmap_id| equals |new_bitmap_data|.
708 bool IsFaviconBitmapDataEqual(
709 FaviconBitmapID bitmap_id,
710 const scoped_refptr<base::RefCountedMemory>& new_bitmap_data);
711
707 // Returns true if there are favicons for |page_url| and one of the types in 712 // Returns true if there are favicons for |page_url| and one of the types in
708 // |icon_types|. 713 // |icon_types|.
709 // |favicon_bitmap_results| is set to the favicon bitmaps which most closely 714 // |favicon_bitmap_results| is set to the favicon bitmaps which most closely
710 // match |desired_size_in_dip| and |desired_scale_factors|. If 715 // match |desired_size_in_dip| and |desired_scale_factors|. If
711 // |desired_size_in_dip| is 0, the largest favicon bitmap with one of the icon 716 // |desired_size_in_dip| is 0, the largest favicon bitmap with one of the icon
712 // types in |icon_types| is returned. If |icon_types| contains multiple icon 717 // types in |icon_types| is returned. If |icon_types| contains multiple icon
713 // types and there are several matched icon types in the database, results 718 // types and there are several matched icon types in the database, results
714 // will only be returned for a single icon type in the priority of 719 // will only be returned for a single icon type in the priority of
715 // TOUCH_PRECOMPOSED_ICON, TOUCH_ICON, and FAVICON. See the comment for 720 // TOUCH_PRECOMPOSED_ICON, TOUCH_ICON, and FAVICON. See the comment for
716 // GetFaviconResultsForBestMatch() for more details on how 721 // GetFaviconResultsForBestMatch() for more details on how
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
902 // Used to provide the Android ContentProvider APIs. 907 // Used to provide the Android ContentProvider APIs.
903 scoped_ptr<AndroidProviderBackend> android_provider_backend_; 908 scoped_ptr<AndroidProviderBackend> android_provider_backend_;
904 #endif 909 #endif
905 910
906 DISALLOW_COPY_AND_ASSIGN(HistoryBackend); 911 DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
907 }; 912 };
908 913
909 } // namespace history 914 } // namespace history
910 915
911 #endif // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_ 916 #endif // CHROME_BROWSER_HISTORY_HISTORY_BACKEND_H_
OLDNEW
« no previous file with comments | « base/memory/ref_counted_memory_unittest.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698