Make ui_resources IDRs accessible via chrome://theme/<IDR>.

Make ui_resources IDRs accessible via chrome://theme/<IDR>.

This helps cleanly move chrome/app/theme images to ui/resources.

TODO(followup): Cleanup WebUI usage of ui/resources images.
TODO(followup): Use a new handler like chrome://ui/ instead?
(that seems like a bit of work for little tangible benefit)

BUG=166075
TEST=ui/resources/ui_resources.grd IDRs are accessible like chrome://theme/IDR_CHECKMARK
R=oshima@chromium.org,sky@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175714

[msw, 2013-01-08 21:43:14]

Hey Oshima and Scott, please take a look; thanks!

[oshima, 2013-01-08 22:36:33]

lgtm with nit

https://codereview.chromium.org/11830002/diff/4001/chrome/browser/resources_u...
File chrome/browser/resources_util_unittest.cc (right):

https://codereview.chromium.org/11830002/diff/4001/chrome/browser/resources_u...
chrome/browser/resources_util_unittest.cc:15: } cases[] = {
shouldn't this still be kTestCases as it's still const?

[sky, 2013-01-08 22:51:33]

https://codereview.chromium.org/11830002/diff/4001/chrome/browser/resources_u...
File chrome/browser/resources_util.cc (right):

https://codereview.chromium.org/11830002/diff/4001/chrome/browser/resources_u...
chrome/browser/resources_util.cc:27: id_map_[kUiResources[i].name] =
kUiResources[i].value;
Are we sure the names are unique here? Meaning they won't overlap with
kThemeResources?

[msw, 2013-01-08 23:07:37]

https://codereview.chromium.org/11830002/diff/4001/chrome/browser/resources_u...
File chrome/browser/resources_util.cc (right):

https://codereview.chromium.org/11830002/diff/4001/chrome/browser/resources_u...
chrome/browser/resources_util.cc:27: id_map_[kUiResources[i].name] =
kUiResources[i].value;
On 2013/01/08 22:51:33, sky wrote:
> Are we sure the names are unique here? Meaning they won't overlap with
> kThemeResources?

I just manually ensured that none do. I also tried defining IDR_MESSAGE_CLOSE in
ui_resources.grd (it's already defined in theme_resources.grd), and this yielded
compile errors, so I don't think additional checks are necessary:

d:\src\chrome-git\src\out\debug\gen\ui\ui_resources\grit\ui_resources.h(192) :
error C2220: warning treated as error - no 'object' file generated
d:\src\chrome-git\src\out\debug\gen\ui\ui_resources\grit\ui_resources.h(192) :
warning C4005: 'IDR_TAB_CLOSE' : macro redefinition
        d:\src\chrome-git\src\out\debug\gen\chrome\grit\theme_resources.h(481) :
see previous definition of 'IDR_TAB_CLOSE'

https://codereview.chromium.org/11830002/diff/4001/chrome/browser/resources_u...
File chrome/browser/resources_util_unittest.cc (right):

https://codereview.chromium.org/11830002/diff/4001/chrome/browser/resources_u...
chrome/browser/resources_util_unittest.cc:15: } cases[] = {
On 2013/01/08 22:36:34, oshima wrote:
> shouldn't this still be kTestCases as it's still const?

Done. For some reason, I thought I had seen the opposite recommendation for
local const identifiers.

[oshima, 2013-01-08 23:10:26]

https://codereview.chromium.org/11830002/diff/4001/chrome/browser/resources_u...
File chrome/browser/resources_util_unittest.cc (right):

https://codereview.chromium.org/11830002/diff/4001/chrome/browser/resources_u...
chrome/browser/resources_util_unittest.cc:15: } cases[] = {
On 2013/01/08 23:07:37, msw wrote:
> On 2013/01/08 22:36:34, oshima wrote:
> > shouldn't this still be kTestCases as it's still const?
> 
> Done. For some reason, I thought I had seen the opposite recommendation for
> local const identifiers.

If that's recommended style, then I'm fine. I just wasn't aware of it.

[sky, 2013-01-09 00:43:03]

LGTM

[commit-bot: I haz the power, 2013-01-09 00:47:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/11830002/4

[commit-bot: I haz the power, 2013-01-09 05:35:25]

Change committed as 175714