Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 11829052: cc: Don't apply --enable-impl-side-painting to browser compositor (Closed)

Created:
7 years, 11 months ago by enne (OOO)
Modified:
7 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

cc: Don't apply --enable-impl-side-painting to browser compositor Checking the command line in LayerTreeSettings is dangerous, as both the browser and the renderer will have the same command line args. Moving this flag first, as it causes asserts in debug for --enable-impl-side-painting. The other flags can be moved separately. R=danakj@chromium.org BUG=169173, 155209 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176135

Patch Set 1 #

Patch Set 2 : Base files missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
enne (OOO)
7 years, 11 months ago (2013-01-10 03:08:19 UTC) #1
nduca
LGTM fwiw
7 years, 11 months ago (2013-01-10 10:57:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11829052/1002
7 years, 11 months ago (2013-01-10 15:33:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-10 15:48:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11829052/1002
7 years, 11 months ago (2013-01-10 16:33:28 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
7 years, 11 months ago (2013-01-10 18:45:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11829052/1002
7 years, 11 months ago (2013-01-10 18:56:48 UTC) #7
commit-bot: I haz the power
Change committed as 176135
7 years, 11 months ago (2013-01-10 20:04:52 UTC) #8
danakj
7 years, 11 months ago (2013-01-11 00:49:32 UTC) #9
Message was sent while issue was closed.
lgtm2

Powered by Google App Engine
This is Rietveld 408576698