[Spellcheck] Turning spelling service on by default. Adding command line flag to turn spelling serv…

[Spellcheck] Turning spelling service on by default. Adding command line flag to turn spelling service off for testing purposes.


BUG=122203, 107371
TBR=brettw@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176201

[rpetterson, 2013-01-09 23:16:34]

groby - spellcheck
jhawkins - browser_options owners
brettw - tab_contents owners

[groby-ooo-7-16, 2013-01-10 01:00:55]

https://codereview.chromium.org/11829042/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/11829042/diff/1/chrome/common/chrome_switches...
chrome/common/chrome_switches.cc:1327: const char kUseSpellingSuggestions[]     
      = "use-spelling-suggestions";
So we _always_ get suggestions? Shouldn't this then be disable-spelling-service?

[rpetterson, 2013-01-10 01:06:10]

https://codereview.chromium.org/11829042/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/11829042/diff/1/chrome/common/chrome_switches...
chrome/common/chrome_switches.cc:1327: const char kUseSpellingSuggestions[]     
      = "use-spelling-suggestions";
On 2013/01/10 01:00:56, groby wrote:
> So we _always_ get suggestions? Shouldn't this then be
disable-spelling-service?

If you want to disable the spelling service, uncheck "Ask Google for
Suggestions" (AGFS). I see it the following way:

If AGFS is on, we use the spelling service by default
If AGFS is on, but the user has passed the use suggetions flag, we revert to
suggestions.

There is another pref (kUseSpellCheckSpellingService) which might be what you're
thinking of? I haven't touched that one.

[groby-ooo-7-16, 2013-01-10 01:36:45]

LGTM 

(results of offline discussion. Basically, no *good* name for this flag is
possible, and it's test only/will be killed soon-ish)

[rpetterson, 2013-01-10 01:44:38]

Removing jhawkins as a review since browser_options.html was removed.

Making brettw TBR reviewer since the change in tab_contents is a trivial change
to a test.

[commit-bot: I haz the power, 2013-01-10 18:02:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlp@chromium.org/11829042/1007

[commit-bot: I haz the power, 2013-01-10 22:12:07]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-10 22:16:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlp@chromium.org/11829042/1007

[commit-bot: I haz the power, 2013-01-10 23:24:42]

Change committed as 176201