Fix a couple of GaiaAuthFetcherTest tests to work when non-official keys are used.

Fix a couple of GaiaAuthFetcherTest tests to work when non-official keys are used.

BUG=169093
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176203

[blundell, 2013-01-10 09:12:22]

Just one question. I assume the answer is "Yes" but I'm not enough of an expert
on this code to know for sure.

https://chromiumcodereview.appspot.com/11829038/diff/1/google_apis/gaia/gaia_...
File google_apis/gaia/gaia_auth_fetcher_unittest.cc (right):

https://chromiumcodereview.appspot.com/11829038/diff/1/google_apis/gaia/gaia_...
google_apis/gaia/gaia_auth_fetcher_unittest.cc:858:
google_apis::GetOAuth2ClientID(google_apis::CLIENT_MAIN).c_str());
Is this generic enough to handle all of the different ways that developers can
specify client ID/secret?

[Jói, 2013-01-10 18:46:25]

https://chromiumcodereview.appspot.com/11829038/diff/1/google_apis/gaia/gaia_...
File google_apis/gaia/gaia_auth_fetcher_unittest.cc (right):

https://chromiumcodereview.appspot.com/11829038/diff/1/google_apis/gaia/gaia_...
google_apis/gaia/gaia_auth_fetcher_unittest.cc:858:
google_apis::GetOAuth2ClientID(google_apis::CLIENT_MAIN).c_str());
On 2013/01/10 09:12:22, blundell wrote:
> Is this generic enough to handle all of the different ways that developers can
> specify client ID/secret?

Yes, the interfaces in src/google_api/google_api_keys.h are the single way to
retrieve keys, independent of how they're set.

[Jói, 2013-01-10 18:53:55]

Erik, could you take a look?  Colin already reviewed (did not LGTM yet though)
but does not have full commit privileges yet so I'll need someone else's LGTM.

Cheers,
Jói

[erikwright (departed), 2013-01-10 19:56:08]

LGTM.

[commit-bot: I haz the power, 2013-01-10 21:11:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/11829038/1

[commit-bot: I haz the power, 2013-01-10 23:36:24]

Change committed as 176203

[blundell, 2013-01-11 08:22:51]

LGTM :)