Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 11829034: Add android buildbot step for apk install (Closed)

Created:
7 years, 11 months ago by Isaac (away)
Modified:
7 years, 11 months ago
Reviewers:
boliu
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, cmp
Visibility:
Public.

Description

Add android buildbot step for apk install Step got dropped in python refactor. Adding it back. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175896

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M build/android/buildbot/bb_tests.py View 3 chunks +14 lines, -5 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
Isaac (away)
Bo, would you mind giving this a quick look over for python syntax? Thanks.
7 years, 11 months ago (2013-01-09 21:04:15 UTC) #1
boliu
https://chromiumcodereview.appspot.com/11829034/diff/1/build/android/buildbot/bb_tests.py File build/android/buildbot/bb_tests.py (right): https://chromiumcodereview.appspot.com/11829034/diff/1/build/android/buildbot/bb_tests.py#newcode122 build/android/buildbot/bb_tests.py:122: InstallApk(options, test) from your cl description, wouldn't you want ...
7 years, 11 months ago (2013-01-09 21:13:42 UTC) #2
Isaac (away)
https://chromiumcodereview.appspot.com/11829034/diff/1/build/android/buildbot/bb_tests.py File build/android/buildbot/bb_tests.py (right): https://chromiumcodereview.appspot.com/11829034/diff/1/build/android/buildbot/bb_tests.py#newcode122 build/android/buildbot/bb_tests.py:122: InstallApk(options, test) On 2013/01/09 21:13:42, boliu wrote: > from ...
7 years, 11 months ago (2013-01-09 21:17:31 UTC) #3
boliu
lgtm https://chromiumcodereview.appspot.com/11829034/diff/1/build/android/buildbot/bb_tests.py File build/android/buildbot/bb_tests.py (right): https://chromiumcodereview.appspot.com/11829034/diff/1/build/android/buildbot/bb_tests.py#newcode122 build/android/buildbot/bb_tests.py:122: InstallApk(options, test) On 2013/01/09 21:17:31, Isaac wrote: > ...
7 years, 11 months ago (2013-01-09 21:20:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11829034/1
7 years, 11 months ago (2013-01-09 21:27:49 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 21:52:58 UTC) #6
Message was sent while issue was closed.
Change committed as 175896

Powered by Google App Engine
This is Rietveld 408576698