Add the ability to activate for carriers that need to be directly activated.

Add the ability to activate for carriers that need to be directly activated.
Currently if we try to activate on a carrier like Sprint, which does not use any activation process, we'll not be able to via the UI. In fact, we'll end up using the Verizon activation process which will completely fail. This CL fixes that.
Additionally, this CL also fixes the issue that once the details page is up, the connection state data (and the corresponding state of the various buttons on the page) is not updated as the network updates itself. This affects celluar but also WiFi.

R=gspencer@chromium.org
BUG=chrome-os-partner:14111
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175984

[Greg Spencer (Chromium), 2013-01-09 19:34:32]

LGTM, w/nit

https://codereview.chromium.org/11829015/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/11829015/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:552: if
(device->technology_family() == chromeos::TECHNOLOGY_FAMILY_GSM)
Why do we need to check this if we then check for Sprint?  Seems redundant.

[rkc, 2013-01-09 22:19:13]

Fixed comment + added Nikita for OWNER's review.

https://codereview.chromium.org/11829015/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/11829015/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:552: if
(device->technology_family() == chromeos::TECHNOLOGY_FAMILY_GSM)
On 2013/01/09 19:34:32, Greg Spencer (Chromium) wrote:
> Why do we need to check this if we then check for Sprint?  Seems redundant.

You're right, the check is superfluous, removed.
Done.

[Evan Stade, 2013-01-09 23:24:08]

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/resources/o...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/resources/o...
chrome/browser/resources/options/chromeos/internet_detail.js:45: if (prop in
data) {
no curlies

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/resources/o...
chrome/browser/resources/options/chromeos/internet_detail.js:729: if
(data.showActivateButton) {
no curlies

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:534:
chromeos::Network *network = NULL;
asterisk before space

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:535: if
(!service_path.empty())
curlies

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:541:
(chromeos::CellularNetwork*) network;
use c++ style casts

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:551: if
(device->carrier() == shill::kCarrierSprint)
nit: return device->carrier() == shill::kCarrierSprint;

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.h
(right):

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.h:127:
base::DictionaryValue* dictionary);
indent

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.h:151: //
Updates the display of network connection
wrap at 80

[rkc, 2013-01-09 23:34:35]

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/resources/o...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/resources/o...
chrome/browser/resources/options/chromeos/internet_detail.js:45: if (prop in
data) {
On 2013/01/09 23:24:08, Evan Stade wrote:
> no curlies

Done.

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/resources/o...
chrome/browser/resources/options/chromeos/internet_detail.js:729: if
(data.showActivateButton) {
On 2013/01/09 23:24:08, Evan Stade wrote:
> no curlies

Done.

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:534:
chromeos::Network *network = NULL;
On 2013/01/09 23:24:08, Evan Stade wrote:
> asterisk before space

Done.

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:535: if
(!service_path.empty())
On 2013/01/09 23:24:08, Evan Stade wrote:
> curlies

Done.

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:541:
(chromeos::CellularNetwork*) network;
On 2013/01/09 23:24:08, Evan Stade wrote:
> use c++ style casts

Done.

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:551: if
(device->carrier() == shill::kCarrierSprint)
On 2013/01/09 23:24:08, Evan Stade wrote:
> nit: return device->carrier() == shill::kCarrierSprint;
Fixed an unlikely but possible bug also.
Done.

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.h
(right):

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.h:127:
base::DictionaryValue* dictionary);
On 2013/01/09 23:24:08, Evan Stade wrote:
> indent

Done.

https://codereview.chromium.org/11829015/diff/3002/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.h:151: //
Updates the display of network connection
On 2013/01/09 23:24:08, Evan Stade wrote:
> wrap at 80

Done.

[Evan Stade, 2013-01-09 23:49:29]

lgtm with a few more nits

https://codereview.chromium.org/11829015/diff/9001/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/11829015/diff/9001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:535: if
(!service_path.empty()) {
you aren't supposed to handle DCHECK failures, but if you are particularly
worried about this one, you should do:

if (service_path.empty()) {
  NOTREACHED();
  return;
}

at the beginning of the function.

https://codereview.chromium.org/11829015/diff/9001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:545:
cell_network->StartActivation();
L543-545 could be combined to one.

https://codereview.chromium.org/11829015/diff/9001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1385:
cros_->virtual_network_connected());
indent

https://codereview.chromium.org/11829015/diff/9001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1536:
dictionary->SetBoolean(kTagDisableConnectButton, true);
dictionary->SetBoolean(kTagDisableConnectButton, condition)

[rkc, 2013-01-09 23:59:10]

https://codereview.chromium.org/11829015/diff/9001/chrome/browser/ui/webui/op...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/11829015/diff/9001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:535: if
(!service_path.empty()) {
On 2013/01/09 23:49:29, Evan Stade wrote:
> you aren't supposed to handle DCHECK failures, but if you are particularly
> worried about this one, you should do:
> 
> if (service_path.empty()) {
>   NOTREACHED();
>   return;
> }
> 
> at the beginning of the function.

Done.

https://codereview.chromium.org/11829015/diff/9001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:545:
cell_network->StartActivation();
On 2013/01/09 23:49:29, Evan Stade wrote:
> L543-545 could be combined to one.

Done.

https://codereview.chromium.org/11829015/diff/9001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1385:
cros_->virtual_network_connected());
On 2013/01/09 23:49:29, Evan Stade wrote:
> indent

Done.

https://codereview.chromium.org/11829015/diff/9001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1536:
dictionary->SetBoolean(kTagDisableConnectButton, true);
On 2013/01/09 23:49:29, Evan Stade wrote:
> dictionary->SetBoolean(kTagDisableConnectButton, condition)

Done.

[commit-bot: I haz the power, 2013-01-10 00:01:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/11829015/8002

[commit-bot: I haz the power, 2013-01-10 02:08:54]

Change committed as 175984