Issue 11828044: Android: fixes "device_status_check.py" for missing status.

Issue 11828044: Android: fixes "device_status_check.py" for missing status. (Closed)

Created:
7 years, 11 months ago by bulach

Modified:
7 years, 11 months ago

Reviewers:
Isaac (away), Isaac (use chromium)

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: fixes "device_status_check.py" for missing status. Some android devices don't report battery status, fail gracefuly. BUG=169183 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176321

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	build/android/device_status_check.py	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Isaac (use chromium)

LGTM https://codereview.chromium.org/11828044/diff/1/build/android/device_status_check.py File build/android/device_status_check.py (right): https://codereview.chromium.org/11828044/diff/1/build/android/device_status_check.py#newcode40 build/android/device_status_check.py:40: if battery.find('Error') == 0: nit will this work? ...

7 years, 11 months ago (2013-01-10 20:21:52 UTC) #2

bulach

thanks isaac! nit addressed, CQing https://codereview.chromium.org/11828044/diff/1/build/android/device_status_check.py File build/android/device_status_check.py (right): https://codereview.chromium.org/11828044/diff/1/build/android/device_status_check.py#newcode40 build/android/device_status_check.py:40: if battery.find('Error') == 0: ...

7 years, 11 months ago (2013-01-11 10:04:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11828044/4001

7 years, 11 months ago (2013-01-11 10:04:37 UTC) #4

Message was sent while issue was closed.

Change committed as 176321

Expand Messages | Collapse Messages