Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 11828035: First cut at UI for saving net_logs data into a temporary file on (Closed)

Created:
7 years, 11 months ago by ramant (doing other things)
Modified:
7 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, mmenke, eroman
Visibility:
Public.

Description

First cut at UI for saving net_logs data into a temporary file on Mobile (Android and iOS). Added a new page chrome://net-export to start/stop/send the net_log for mobile platforms. Button "Start Saving (after deleting old data)" will start saving to a temporary file in "NetLog" directory in Temp directory. It deletes all the old temporary files that were in that directory before creating a new temporty file. It is a no-op if we are already saving data into a file. Button "Stop Saving Data" closes the temporary file so that it could be mailed. It is a no-op if we haven't started saving data into a file. Button "Send Data" emails the data file if a temporary file exists in "NetLog" directory. It is a no-op if there is no file. There is only a single temporary file into which we log the data. NetLog data is saved in the browser process. Logging of net_log data behaves similar to the command line option --log-net-log. If chrome://net-export is accessed in multiple tabs, action in first tab wins. If Stop is clicked in any tab, logging stops. If start is clicked in any tab, net logging starts. mmenke@ and/or eroman@ for chrome\browser\resources and webui changes. jar@ for net_log_temp_file changes. jhawkins@chromium.org for chrome\browser\ui\webui and chrome\browser\resources OWNERS stamp. R=jar@chromium.org, mmenke@chromium.org BUG=151212 TEST=chrome://net-export

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+756 lines, -1 line) Patch
build/ios/grit_whitelist.txt View 1 chunk +2 lines, -0 lines 0 comments Download
chrome/browser/browser_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
chrome/browser/net/chrome_net_log.h View 3 chunks +6 lines, -0 lines 0 comments Download
chrome/browser/net/chrome_net_log.cc View 1 chunk +3 lines, -1 line 0 comments Download
chrome/browser/net/net_log_logger.h View 1 chunk +3 lines, -0 lines 0 comments Download
chrome/browser/net/net_log_logger.cc View 1 chunk +4 lines, -0 lines 0 comments Download
chrome/browser/net/net_log_temp_file.h View 1 chunk +96 lines, -0 lines 0 comments Download
chrome/browser/net/net_log_temp_file.cc View 1 chunk +208 lines, -0 lines 0 comments Download
chrome/browser/resources/net_export/net_export.html View 1 chunk +61 lines, -0 lines 0 comments Download
chrome/browser/resources/net_export/net_export.js View 1 chunk +175 lines, -0 lines 0 comments Download
chrome/browser/resources/web_dev_style/js_checker.py View 1 chunk +1 line, -0 lines 0 comments Download
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +3 lines, -0 lines 0 comments Download
chrome/browser/ui/webui/net_export_ui.h View 1 chunk +20 lines, -0 lines 0 comments Download
chrome/browser/ui/webui/net_export_ui.cc View 1 chunk +166 lines, -0 lines 0 comments Download
chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
chrome/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
chrome/common/url_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698