Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11828034: Move android gtest filter files into pylib dir (Closed)

Created:
7 years, 11 months ago by Isaac (away)
Modified:
7 years, 11 months ago
Reviewers:
frankf
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Move android gtest filter files into pylib dir As part of a general refactor of build/android, clean up gtest_filter by moving those files to a better location. BUG=167331 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176649

Patch Set 1 : #

Total comments: 2

Patch Set 2 : addr frankf comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -320 lines) Patch
D build/android/gtest_filter/base_unittests_disabled View 1 chunk +0 lines, -27 lines 0 comments Download
D build/android/gtest_filter/base_unittests_emulator_additional_disabled View 1 chunk +0 lines, -10 lines 0 comments Download
D build/android/gtest_filter/breakpad_unittests_disabled View 1 chunk +0 lines, -5 lines 0 comments Download
D build/android/gtest_filter/content_unittests_disabled View 1 chunk +0 lines, -23 lines 0 comments Download
D build/android/gtest_filter/ipc_tests_disabled View 1 1 chunk +0 lines, -15 lines 0 comments Download
D build/android/gtest_filter/media_unittests_disabled View 1 chunk +0 lines, -11 lines 0 comments Download
D build/android/gtest_filter/net_unittests_disabled View 1 chunk +0 lines, -51 lines 0 comments Download
D build/android/gtest_filter/sync_unit_tests_disabled View 1 chunk +0 lines, -4 lines 0 comments Download
D build/android/gtest_filter/ui_unittests_disabled View 1 chunk +0 lines, -40 lines 0 comments Download
D build/android/gtest_filter/unit_tests_disabled View 1 chunk +0 lines, -121 lines 0 comments Download
D build/android/gtest_filter/webkit_unit_tests_disabled View 1 chunk +0 lines, -8 lines 0 comments Download
A + build/android/pylib/gtest/filter/base_unittests_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/filter/base_unittests_emulator_additional_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/filter/breakpad_unittests_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/filter/content_unittests_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/filter/ipc_tests_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/filter/media_unittests_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/filter/net_unittests_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/filter/sync_unit_tests_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/filter/ui_unittests_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/filter/unit_tests_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/pylib/gtest/filter/webkit_unit_tests_disabled View 0 chunks +-1 lines, --1 lines 0 comments Download
M build/android/pylib/gtest/single_test_runner.py View 1 2 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Isaac (away)
For you, Frank, all for you.
7 years, 11 months ago (2013-01-10 04:17:25 UTC) #1
frankf
lgtm. https://codereview.chromium.org/11828034/diff/6001/build/android/pylib/gtest/single_test_runner.py File build/android/pylib/gtest/single_test_runner.py (right): https://codereview.chromium.org/11828034/diff/6001/build/android/pylib/gtest/single_test_runner.py#newcode91 build/android/pylib/gtest/single_test_runner.py:91: A list of disabled tests obtained from gtest_filter/test_suite_disabled. ...
7 years, 11 months ago (2013-01-10 18:49:05 UTC) #2
frankf
https://codereview.chromium.org/11828034/diff/6001/build/android/pylib/gtest/single_test_runner.py File build/android/pylib/gtest/single_test_runner.py (right): https://codereview.chromium.org/11828034/diff/6001/build/android/pylib/gtest/single_test_runner.py#newcode95 build/android/pylib/gtest/single_test_runner.py:95: self.test_package.test_suite_basename) Oh, and this can be relative to __file__
7 years, 11 months ago (2013-01-10 18:50:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11828034/16001
7 years, 11 months ago (2013-01-14 10:22:48 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-14 10:23:34 UTC) #5
Message was sent while issue was closed. 
Change committed as 176649

Powered by Google App Engine
This is Rietveld 408576698