Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 11828026: Remove DeviceAttachedIntentSource. (Closed)

Created:
7 years, 11 months ago by Greg Billock
Modified:
7 years, 11 months ago
CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org, groby+watch_chromium.org, rouslan+watch_chromium.org
Visibility:
Public.

Description

Remove DeviceAttachedIntentSource. R=groby@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -230 lines) Patch
D chrome/browser/intents/device_attached_intent_source.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/intents/device_attached_intent_source.cc View 1 chunk +0 lines, -156 lines 0 comments Download
M chrome/browser/ui/browser.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Greg Billock
7 years, 11 months ago (2013-01-09 19:41:15 UTC) #1
groby-ooo-7-16
lgtm
7 years, 11 months ago (2013-01-09 19:47:50 UTC) #2
groby-ooo-7-16
lgtm lgtm
7 years, 11 months ago (2013-01-09 19:47:51 UTC) #3
Greg Billock
On 2013/01/09 19:47:51, groby wrote: > lgtm > > lgtm Added sky,thestig for owners.
7 years, 11 months ago (2013-01-09 20:03:46 UTC) #4
Lei Zhang
lgtm
7 years, 11 months ago (2013-01-09 20:12:39 UTC) #5
Lei Zhang
BTW, if there's a bug for removing intents bits, add it to BUG=
7 years, 11 months ago (2013-01-09 20:13:21 UTC) #6
sky
LGTM
7 years, 11 months ago (2013-01-09 20:49:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/11828026/1
7 years, 11 months ago (2013-01-09 21:16:03 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 01:28:08 UTC) #9
Message was sent while issue was closed.
Change committed as 175969

Powered by Google App Engine
This is Rietveld 408576698