Issue 11828009: Ensure nacl_integration does not report UMA stats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11828009: Ensure nacl_integration does not report UMA stats. (Closed)

Created:
7 years, 11 months ago by Nick Bray (chromium)

Modified:
7 years, 11 months ago

Reviewers:
Mark Seaborn

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ensure nacl_integration does not report UMA stats. There is no known issues with UMA poisoning, but a command line flag has been added to make sure. BUG= none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175870

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

LGTM https://codereview.chromium.org/11828009/diff/1/ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py File ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py (right): https://codereview.chromium.org/11828009/diff/1/ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py#newcode276 ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py:276: # Suppress metrics reporting. Add more explanation? Maybe ...

7 years, 11 months ago (2013-01-09 00:20:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/11828009/9003

7 years, 11 months ago (2013-01-09 17:46:42 UTC) #3

Message was sent while issue was closed.

Change committed as 175870

Expand Messages | Collapse Messages