Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2116)

Unified Diff: content/renderer/browser_plugin/browser_plugin_browsertest.cc

Issue 11828005: Fixing resize for HW accelerated compositing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed tests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/browser_plugin/browser_plugin_browsertest.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_browsertest.cc b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
index 9f02db1b87a1c352bfea4d241ec969a8e9baa4d2..5694b695d60060b1b708c887adbe643074f4d786 100644
--- a/content/renderer/browser_plugin/browser_plugin_browsertest.cc
+++ b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
@@ -153,6 +153,7 @@ TEST_F(BrowserPluginTest, InitialResize) {
update_rect_params.view_size = gfx::Size(640, 480);
update_rect_params.scale_factor = 1.0f;
update_rect_params.is_resize_ack = true;
+ update_rect_params.needs_ack = true;
BrowserPluginMsg_UpdateRect msg(0, instance_id, update_rect_params);
browser_plugin->OnMessageReceived(msg);
EXPECT_FALSE(browser_plugin->pending_damage_buffer_.get());
@@ -235,6 +236,7 @@ TEST_F(BrowserPluginTest, ResizeFlowControl) {
update_rect_params.view_size = gfx::Size(640, 480);
update_rect_params.scale_factor = 1.0f;
update_rect_params.is_resize_ack = true;
+ update_rect_params.needs_ack = true;
// By sending |damage_buffer_sequence_id| back to BrowserPlugin on
// UpdateRect, then the BrowserPlugin knows that the browser process has
// received and has begun to use the |pending_damage_buffer_|.
@@ -277,6 +279,7 @@ TEST_F(BrowserPluginTest, ResizeFlowControl) {
update_rect_params.view_size = gfx::Size(641, 480);
update_rect_params.scale_factor = 1.0f;
update_rect_params.is_resize_ack = true;
+ update_rect_params.needs_ack = true;
update_rect_params.damage_buffer_sequence_id =
browser_plugin->damage_buffer_sequence_id_;
BrowserPluginMsg_UpdateRect msg(0, instance_id, update_rect_params);
@@ -292,6 +295,7 @@ TEST_F(BrowserPluginTest, ResizeFlowControl) {
update_rect_params.view_size = gfx::Size(643, 480);
update_rect_params.scale_factor = 1.0f;
update_rect_params.is_resize_ack = true;
+ update_rect_params.needs_ack = true;
update_rect_params.damage_buffer_sequence_id =
browser_plugin->damage_buffer_sequence_id_;
BrowserPluginMsg_UpdateRect msg(0, instance_id, update_rect_params);
@@ -813,6 +817,7 @@ TEST_F(BrowserPluginTest, AutoSizeAttributes) {
update_rect_params.view_size = gfx::Size(1337, 1338);
update_rect_params.scale_factor = 1.0f;
update_rect_params.is_resize_ack = true;
+ update_rect_params.needs_ack = true;
BrowserPluginMsg_UpdateRect msg(0, instance_id, update_rect_params);
browser_plugin->OnMessageReceived(msg);
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698