Ensure "Press Tab to search" is never displayed when instant extended is enabled.

Ensure "Press Tab to search" is never displayed when instant extended is enabled.

BUG=167172
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176622

[beaudoin, 2013-01-10 22:12:24]

Hey Scott! Peter is my usual reviewer on my omnibox change but I think he's away
for a while. If you could take a look at this, it's a small one.

Thanks!

[dhollowa, 2013-01-10 22:37:48]

Moving myself to cc, sky@ and/or pkasting@ are better choices for this.

[sky, 2013-01-11 00:15:57]

This LGTM, but how about test coverage?

https://codereview.chromium.org/11827060/diff/1/chrome/browser/ui/omnibox/omn...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (right):

https://codereview.chromium.org/11827060/diff/1/chrome/browser/ui/omnibox/omn...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:215: const bool
save_original_selection = !has_temporary_text_;
nit: use {} since you're adding a variable only for this section.

[beaudoin, 2013-01-13 20:02:39]

I'll go ahead and send to CQ since it helps with a few bugs in this area. For
test coverage, I've added a note to crbug.com/167359 so that it does not slip in
the cracks.

Thanks for the review!

https://codereview.chromium.org/11827060/diff/1/chrome/browser/ui/omnibox/omn...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (right):

https://codereview.chromium.org/11827060/diff/1/chrome/browser/ui/omnibox/omn...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:215: const bool
save_original_selection = !has_temporary_text_;
On 2013/01/11 00:15:57, sky wrote:
> nit: use {} since you're adding a variable only for this section.

Done.

[commit-bot: I haz the power, 2013-01-13 20:03:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/beaudoin@chromium.org/11827060/1

[commit-bot: I haz the power, 2013-01-13 20:04:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/beaudoin@chromium.org/11827060/14002

[commit-bot: I haz the power, 2013-01-13 21:43:15]

Retried try job too often on mac_rel for step(s) browser_tests

[commit-bot: I haz the power, 2013-01-13 22:02:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/beaudoin@chromium.org/11827060/14002

[commit-bot: I haz the power, 2013-01-14 01:09:50]

Change committed as 176622

[Peter Kasting, 2013-01-17 05:42:25]

For reference, this change title is VERY confusing if your goal was simply to
disable the message on "inappropriate" entries.

[sreeram, 2013-01-31 19:30:50]

In addition, it violated an assumption in InstantController, leading to
http://crbug.com/172382. Not a big deal, @asvitkine will fix it. Probably shows
how brittle the Instant code is. Sigh.