Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 11827057: Fix findbugs issues (Closed)

Created:
7 years, 11 months ago by Kristian Monsen
Modified:
7 years, 11 months ago
Reviewers:
bulach, Yaron
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Fix findbugs issues Constants should be private static final. Since I'm there, renamed TAG to LOGTAG so it is obvious it is only used for logging. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176288

Patch Set 1 #

Patch Set 2 : Renamed LOGTAG back to TAG #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Kristian Monsen
I was looking at the find bugs list. A lot of them have simple fixes, ...
7 years, 11 months ago (2013-01-10 23:28:16 UTC) #1
Yaron
lgtm We use TAG everywhere (I think it's fairly typical) but this is fine. Thanks ...
7 years, 11 months ago (2013-01-10 23:41:02 UTC) #2
Kristian Monsen
Thanks! Renamed it back to TAG, that was not the important part.
7 years, 11 months ago (2013-01-10 23:59:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/11827057/6001
7 years, 11 months ago (2013-01-11 03:08:14 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration
7 years, 11 months ago (2013-01-11 05:23:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/11827057/6001
7 years, 11 months ago (2013-01-11 05:26:41 UTC) #6
commit-bot: I haz the power
Change committed as 176288
7 years, 11 months ago (2013-01-11 08:53:35 UTC) #7
bulach
7 years, 11 months ago (2013-01-11 11:56:37 UTC) #8
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698