Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 11827039: Make all nss targets build on Win64 (Closed)

Created:
7 years, 11 months ago by jschuh
Modified:
7 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Make all nss targets build on Win64 BUG=166496 BUG=167187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M nss.gyp View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jschuh
This seems right, but I figure I want a sanity check rather than just TBRing ...
7 years, 11 months ago (2013-01-10 00:06:09 UTC) #1
Ryan Sleevi
Yeah. I have https://codereview.chromium.org/11738002/ to fix the ASM exclusions (pending GYP || upstream NSS changes) ...
7 years, 11 months ago (2013-01-10 00:09:44 UTC) #2
jschuh
On 2013/01/10 00:09:44, Ryan Sleevi wrote: > Yeah. I have https://codereview.chromium.org/11738002/ to fix the ASM ...
7 years, 11 months ago (2013-01-10 00:16:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/11827039/1
7 years, 11 months ago (2013-01-10 00:16:24 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 00:16:35 UTC) #5
Message was sent while issue was closed.
Change committed as 175939

Powered by Google App Engine
This is Rietveld 408576698