cc: Prohibit impl-side painting with single threaded compositing

cc: Prohibit impl-side painting with single threaded compositing

Just a little cleanup and some extra checks.

R=danakj@chromium.org
BUG=155209
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175981

[danakj, 2013-01-09 23:19:03]

lgtm

On Wednesday, January 9, 2013, wrote:

> Reviewers: danakj,
>
> Description:
> cc: Prohibit impl-side painting with single threaded compositing
>
> Just a little cleanup and some extra checks.
>
> R=danakj@chromium.org
> BUG=155209
>
>
> Please review this at
https://codereview.chromium.**org/11827036/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   cc/single_thread_proxy.cc
>
>
> Index: cc/single_thread_proxy.cc
> diff --git a/cc/single_thread_proxy.cc b/cc/single_thread_proxy.cc
> index 9cccd0ff4952f34e64da2e3ff07af3**42fbbef60f..**
> 96418bbaa268ba764f8928a08e9ea4**aff8281796 100644
> --- a/cc/single_thread_proxy.cc
> +++ b/cc/single_thread_proxy.cc
> @@ -29,6 +29,10 @@ SingleThreadProxy::**SingleThreadProxy(**LayerTreeHost*
> layerTreeHost)
>  {
>      TRACE_EVENT0("cc", "SingleThreadProxy::**SingleThreadProxy");
>      DCHECK(Proxy::isMainThread());
> +    DCHECK(layerTreeHost);
> +
> +    // Impl-side painting not supported without threaded compositing
> +    DCHECK(!layerTreeHost->**settings().implSidePainting);
>  }
>
>  void SingleThreadProxy::start()
> @@ -361,9 +365,6 @@ bool SingleThreadProxy::**doComposite()
>
>          m_layerTreeHostImpl->animate(**base::TimeTicks::Now(),
> base::Time::Now());
>
> -        if (m_layerTreeHostImpl->**settings().implSidePainting)
> -          m_layerTreeHostImpl->**manageTiles();
> -
>          // We guard prepareToDraw() with canDraw() because it always
> returns a valid frame, so can only
>          // be used when such a frame is possible. Since drawLayers()
> depends on the result of
>          // prepareToDraw(), it is guarded on canDraw() as well.
>
>
>

[commit-bot: I haz the power, 2013-01-09 23:21:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enne@chromium.org/11827036/2001

[commit-bot: I haz the power, 2013-01-10 02:05:24]

Change committed as 175981