Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 11827032: Add DVLOG() macros for better debugging to the webNavigation API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
index 957b7c5b0f8df16229359694862074ceb15caccc..841a7fc5c0e8b5399952b0eb500b43bee7c64420 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
@@ -363,6 +363,10 @@ void WebNavigationTabObserver::DidStartProvisionalLoadForFrame(
bool is_error_page,
bool is_iframe_srcdoc,
content::RenderViewHost* render_view_host) {
+ DVLOG(2) << "DidStartProvisionalLoad("
+ << "render_view_host=" << render_view_host
+ << ", frame_num=" << frame_num
+ << ", url=" << validated_url << ")";
if (!render_view_host_)
render_view_host_ = render_view_host;
if (render_view_host != render_view_host_ &&
@@ -399,6 +403,10 @@ void WebNavigationTabObserver::DidCommitProvisionalLoadForFrame(
const GURL& url,
content::PageTransition transition_type,
content::RenderViewHost* render_view_host) {
+ DVLOG(2) << "DidCommitProvisionalLoad("
+ << "render_view_host=" << render_view_host
+ << ", frame_num=" << frame_num
+ << ", url=" << url << ")";
if (render_view_host != render_view_host_ &&
render_view_host != pending_render_view_host_)
return;
@@ -476,6 +484,10 @@ void WebNavigationTabObserver::DidFailProvisionalLoad(
int error_code,
const string16& error_description,
content::RenderViewHost* render_view_host) {
+ DVLOG(2) << "DidFailProvisionalLoad("
+ << "render_view_host=" << render_view_host
+ << ", frame_num=" << frame_num
+ << ", url=" << validated_url << ")";
if (render_view_host != render_view_host_ &&
render_view_host != pending_render_view_host_)
return;
@@ -505,6 +517,9 @@ void WebNavigationTabObserver::DidFailProvisionalLoad(
void WebNavigationTabObserver::DocumentLoadedInFrame(
int64 frame_num,
content::RenderViewHost* render_view_host) {
+ DVLOG(2) << "DocumentLoadedInFrame("
+ << "render_view_host=" << render_view_host
+ << ", frame_num=" << frame_num << ")";
if (render_view_host != render_view_host_)
return;
FrameNavigationState::FrameID frame_id(frame_num, render_view_host);
@@ -521,6 +536,10 @@ void WebNavigationTabObserver::DidFinishLoad(
const GURL& validated_url,
bool is_main_frame,
content::RenderViewHost* render_view_host) {
+ DVLOG(2) << "DidFinishLoad("
+ << "render_view_host=" << render_view_host
+ << ", frame_num=" << frame_num
+ << ", url=" << validated_url << ")";
if (render_view_host != render_view_host_)
return;
FrameNavigationState::FrameID frame_id(frame_num, render_view_host);
@@ -548,6 +567,10 @@ void WebNavigationTabObserver::DidFailLoad(
int error_code,
const string16& error_description,
content::RenderViewHost* render_view_host) {
+ DVLOG(2) << "DidFailLoad("
+ << "render_view_host=" << render_view_host
+ << ", frame_num=" << frame_num
+ << ", url=" << validated_url << ")";
if (render_view_host != render_view_host_)
return;
FrameNavigationState::FrameID frame_id(frame_num, render_view_host);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698