tools/json_schema_compiler/test/idl_schemas_unittest.cc - Issue 11827026: Overhaul JSON Schema Compiler to support a number of features required to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/idl_schemas_unittest.cc

Issue 11827026: Overhaul JSON Schema Compiler to support a number of features required to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/json_schema_compiler/test/functions_on_types_unittest.cc ('k') | tools/json_schema_compiler/test/objects_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/json_schema_compiler/test/idl_schemas_unittest.cc

diff --git a/tools/json_schema_compiler/test/idl_schemas_unittest.cc b/tools/json_schema_compiler/test/idl_schemas_unittest.cc

index 8afb59c835c4bbcddcc53e530bedac5045ac9313..5186be9908dc05ba64cb1974d613a8e34c8c9b02 100644

--- a/tools/json_schema_compiler/test/idl_schemas_unittest.cc

+++ b/tools/json_schema_compiler/test/idl_schemas_unittest.cc

@@ -3,7 +3,6 @@

// found in the LICENSE file.

#include "base/values.h"

-#include "tools/json_schema_compiler/any.h"

#include "tools/json_schema_compiler/test/idl_basics.h"

#include "tools/json_schema_compiler/test/idl_object_types.h"

@@ -167,13 +166,12 @@ TEST(IdlCompiler, ObjectTypes) {

// Test the BarType type.

BarType b1;

- base::FundamentalValue seven(7);

- b1.x.Init(seven);

+ b1.x.reset(new base::FundamentalValue(7));

scoped_ptr<DictionaryValue> serialized_bar = b1.ToValue();

BarType b2;

EXPECT_TRUE(BarType::Populate(*serialized_bar.get(), &b2));

int tmp_int = 0;

- EXPECT_TRUE(b2.x.value().GetAsInteger(&tmp_int));

+ EXPECT_TRUE(b2.x->GetAsInteger(&tmp_int));

EXPECT_EQ(7, tmp_int);

// Test the params to the ObjectFunction1 function.