chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc - Issue 11827026: Overhaul JSON Schema Compiler to support a number of features required to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc

Issue 11827026: Overhaul JSON Schema Compiler to support a number of features required to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: yoz Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc » ('j') | tools/json_schema_compiler/cc_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc

index 1ece019e6a397c6c4e7e31d0ecc7cc457b17551c..650face1d6db41671dd772269253fcad8afb7d04 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc

@@ -196,8 +196,7 @@ scoped_ptr<WebRequestConditionSet> WebRequestConditionSet::Create(

i != conditions.end(); ++i) {

CHECK(i->get());

scoped_ptr<WebRequestCondition> condition =

- WebRequestCondition::Create(url_matcher_condition_factory,

- (*i)->value(), error);

+ WebRequestCondition::Create(url_matcher_condition_factory, **i, error);

if (!error->empty())

return scoped_ptr<WebRequestConditionSet>(NULL);

result.push_back(make_linked_ptr(condition.release()));